From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8C6FF6ECE3; Fri, 1 Jul 2022 16:39:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8C6FF6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656682771; bh=yEMjqx+5izRujUAO3Yu3bLC1U9hdKIW01z2WxVNBySE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KJxRjx3uT70bUpgGaapCUJb3I7gjX6+3CZbvw8OD4u2V/05fEtQzeLqF6+Jlf3xPT QZYbGqQNbfmmnh62yxE8YLHxxiZa86MC8CyivWYjrMi0UOz7afJ7wNUTHkH8iZ/8AO HXJY2Z31zNBAbxuGg3xTxKslS4Bp0Wudp/iFGpno= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F34D96ECE3 for ; Fri, 1 Jul 2022 16:39:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F34D96ECE3 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1o7Gro-00023d-AI; Fri, 01 Jul 2022 16:39:29 +0300 Message-ID: <6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org> Date: Fri, 1 Jul 2022 16:39:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> In-Reply-To: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597DC8013B4936CA41749CBF5030FCC38CF6CD62213F67905E7A2E0C2148B923E9250C47B4C98BDDF417E5DE0656CCEBB432ED199C4BD4F2E418 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70D278D70F8433719EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374C1E21D5B12C874B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D879A55F0E099A8A2E1A899E759D786945117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE91ADC097FE2C3A08E7815D572A9D6896D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE364A52DF3AE21010F6E0066C2D8992A16C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006372A310894EFA5E9A9EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1CCFB475D28E08EF204F711384ED80BC5F43965F47FB67280CAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F343DA43F62289FC32D33EDF88CE0BEBEF2657F1128EE04DCDCD43EA2F8DE32A92E752C0D4C0C101D7E09C32AA3244C8D2E71C86DA571571A041AD837B03B1581560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojs3a5nOu33tz1iIraPFHZZw== X-Mailru-Sender: 0A26D9779F8DDEAB8BAA69DB2EA45A4D56A0CDD6DCD0811EB69E8C96EB09AF71A0EEED6465C34208282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM (see my comments inline). On 22.06.2022 18:33, Igor Munkin wrote: > This patch introduces additional steps with Tarantool integration > testing to all existing LuaJIT workflows. All steps invoke reusable > workflow[1] from Tarantool repository for each matrix entry being set > for particular LuaJIT workflow. > > [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml > > Signed-off-by: Igor Munkin > --- > .github/workflows/linux-aarch64.yml | 25 +++++++++++++++-- > .github/workflows/linux-x86_64.yml | 43 +++++++++++++++++++++++++++-- > .github/workflows/macos-m1.yml | 25 +++++++++++++++-- > .github/workflows/macos-x86_64.yml | 43 +++++++++++++++++++++++++++-- > 4 files changed, 124 insertions(+), 12 deletions(-) > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > index de360b12..293b572e 100644 > --- a/.github/workflows/linux-aarch64.yml > +++ b/.github/workflows/linux-aarch64.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (Linux/aarch64)" > +name: "Linux/aarch64 test workflow" > Nit: seems changes here and below with renaming jobs are not related to commit. > on: > push: > @@ -29,7 +29,7 @@ concurrency: > cancel-in-progress: true > > jobs: > - test-linux-aarch64: > + test-luajit: > runs-on: graviton > strategy: > fail-fast: false > @@ -40,7 +40,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:ON > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:ON > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -56,3 +56,22 @@ jobs: > run: cmake --build . --parallel $(($(nproc) + 1)) > - name: test > run: cmake --build . --parallel $(($(nproc) + 1)) --target test > + > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: Debug > + host: graviton > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: graviton > + revision: ${{ github.sha }} > diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux-x86_64.yml > index d6434afe..3eaf436d 100644 > --- a/.github/workflows/linux-x86_64.yml > +++ b/.github/workflows/linux-x86_64.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (Linux/x86_64)" > +name: "Linux/x86_64 test workflow" > > on: > push: > @@ -29,7 +29,7 @@ concurrency: > cancel-in-progress: true > > jobs: > - test-linux-x86_64: > + test-luajit: > runs-on: ubuntu-20.04-self-hosted > strategy: > fail-fast: false > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: Linux/x86_64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -57,3 +57,40 @@ jobs: > run: cmake --build . --parallel $(($(nproc) + 1)) > - name: test > run: cmake --build . --parallel $(($(nproc) + 1)) --target test > + > + test-tarantool-debug-wo-GC64: > + name: Tarantool Debug GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF > + buildtype: Debug > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: Debug > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-release-wo-GC64: > + name: Tarantool Release GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF > + buildtype: RelWithDebInfo > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: ubuntu-20.04-self-hosted > + revision: ${{ github.sha }} > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > index a38f70f7..d305e609 100644 > --- a/.github/workflows/macos-m1.yml > +++ b/.github/workflows/macos-m1.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (macOS/m1)" > +name: "macOS/m1 test workflow" > > on: > push: > @@ -34,7 +34,7 @@ env: > ARCH: arch -arm64 > > jobs: > - test-macos-m1: > + test-luajit: > runs-on: macos-11-m1 > strategy: > fail-fast: false > @@ -45,7 +45,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:ON > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:ON > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -70,3 +70,22 @@ jobs: > run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) > - name: test > run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) --target test > + > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: Debug > + host: macos-11-m1 > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: macos-11-m1 > + revision: ${{ github.sha }} > diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml > index a7c2f4e3..fc28c683 100644 > --- a/.github/workflows/macos-x86_64.yml > +++ b/.github/workflows/macos-x86_64.yml > @@ -1,4 +1,4 @@ > -name: "LuaJIT test workflow (macOS/x86_64)" > +name: "macOS/x86_64 test workflow" > > on: > push: > @@ -29,7 +29,7 @@ concurrency: > cancel-in-progress: true > > jobs: > - test-macos-x86_64: > + test-luajit: > runs-on: macos-11 > strategy: > fail-fast: false > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: macOS/x86_64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -66,3 +66,40 @@ jobs: > run: cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) > - name: test > run: cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) --target test > + > + test-tarantool-debug-wo-GC64: > + name: Tarantool Debug GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF > + buildtype: Debug > + host: macos-11 > + revision: ${{ github.sha }} > + test-tarantool-debug-w-GC64: > + name: Tarantool Debug GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: Debug > + host: macos-11 > + revision: ${{ github.sha }} > + test-tarantool-release-wo-GC64: > + name: Tarantool Release GC64:OFF > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: OFF > + buildtype: RelWithDebInfo > + host: macos-11 > + revision: ${{ github.sha }} > + test-tarantool-release-w-GC64: > + name: Tarantool Release GC64:ON > + needs: test-luajit > + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master > + with: > + GC64: ON > + buildtype: RelWithDebInfo > + host: macos-11 > + revision: ${{ github.sha }}