Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow
Date: Fri, 13 Jan 2023 10:16:04 +0300	[thread overview]
Message-ID: <Y8EFNI7tr7OcgBsA@root> (raw)
In-Reply-To: <1673566064.971611960@f475.i.mail.ru>

Hi, Igor!
Thanks for the patch!
Nice to see matrix in integrational workflow!
LGTM, with a single nit below.

On 13.01.23, Maxim Kokryashkin wrote:
> 
> Hi!
> Thanks for the patch!
> LGTM, except for a few nits below.
> > 
> >>Considering the changes made in scope of the previous commit, it has

Typo: s/scope/the scope/

> >>been decided to dispatch LuaJIT integration testing to the runner the
> >>similar way (i.e. by using the pair of <matrix.ARCH> + <matrix.OS>
> >>values). As a result a new job with quite similar strategy matrix[1] is
> >>added as a successor for <test-luajit> job. The new job uses the new
> >>version (with <inputs.arch> and <inputs.os> parameters introduced and
> >>optional <inputs.host> obsolete parameter) of LuaJIT integration
> >Typo: s/optional/the optional/
> >Typo: s/of LuaJIT/of the LuaJIT/
> >>workflow from tarantool/tarantool repo.
> >Typo: s/from/from the/
> >>
> >>[1]:  https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow
> >>
> >>Signed-off-by: Igor Munkin < imun@tarantool.org >
> >>---
> >> .github/workflows/testing.yml | 190 ++++++----------------------------
> >> 1 file changed, 30 insertions(+), 160 deletions(-)
> >>
> >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> >>index 5558e3ea..d707ce83 100644
> >>--- a/.github/workflows/testing.yml
> >>+++ b/.github/workflows/testing.yml

<snipped>

> >>2.34.0
> >--
> >Best regards,
> >Maxim Kokryashkin

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2023-01-13  7:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches
2023-01-12 23:23   ` Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
2023-01-16 12:34         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches [this message]
2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
2023-01-16 12:35         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
2023-01-18  9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8EFNI7tr7OcgBsA@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox