From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Date: Mon, 16 Jan 2023 10:55:50 +0300 [thread overview] Message-ID: <Y8UDBqq4X036r5pg@tarantool.org> (raw) In-Reply-To: <Y8ED+N8cH3jftb+F@root> Sergey, Thanks for your review! On 13.01.23, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM, with a single question below. > > On 13.01.23, Maxim Kokryashkin wrote: > > > > Hi, Igor! > > Thanks for the patch! > > LGTM, except for a few nits below. Added your tag: | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org> > > <snipped> > > >>"regular" ones need to be chosen for full LuaJIT testing. At the same > > >>time there is no need to use "regular" runner for LuaJIT Static analysis > > >>workflow, hence 'lightweight' label is added to <runs-on> list in > > >>lint.yml workflow file. > > >Shall we create the same patch for the gnumake workflow? > > I agree here. IMHO, we can use "lightweight" label for gnumake build as > far as it tests only build, so doesn't require a lot of memory. Replied to the Max thread. > <snipped> > > -- > Best regards, > Sergey Kaplun -- Best regards, IM
next prev parent reply other threads:[~2023-01-16 8:10 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches 2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Igor Munkin via Tarantool-patches 2023-01-12 23:23 ` Maxim Kokryashkin via Tarantool-patches 2023-01-13 7:10 ` Sergey Kaplun via Tarantool-patches 2023-01-16 7:55 ` Igor Munkin via Tarantool-patches [this message] 2023-01-16 12:34 ` Maxim Kokryashkin via Tarantool-patches 2023-01-16 7:53 ` Igor Munkin via Tarantool-patches 2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches 2023-01-12 23:27 ` Maxim Kokryashkin via Tarantool-patches 2023-01-13 7:16 ` Sergey Kaplun via Tarantool-patches 2023-01-16 8:00 ` Igor Munkin via Tarantool-patches 2023-01-16 12:35 ` Maxim Kokryashkin via Tarantool-patches 2023-01-16 7:58 ` Igor Munkin via Tarantool-patches 2023-01-18 9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y8UDBqq4X036r5pg@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox