From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 55661164E68; Fri, 13 Jan 2023 10:19:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 55661164E68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1673594367; bh=tO0cZpH//zbSAxTN1lxBn+9RBw7JVpcHoKkWtlbSo98=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MFUJPbQ91asisHCFF62sHoEi35w4JqYyTkL3Hrk9i2glQ+qRWQNLWQ77dz9vJPNBg Dq+quOHR+tw/l1VfjeOXOrv80sX5WFXM17gPC4AJCY3THmelys8qCJfjsokNBhALU9 S8+t+ahf/dLVN09CsHZh8OPrkvnEF0wmTKU6+uvI= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A0E73164E68 for ; Fri, 13 Jan 2023 10:19:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A0E73164E68 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1pGELU-008WCW-U6; Fri, 13 Jan 2023 10:19:25 +0300 Date: Fri, 13 Jan 2023 10:16:04 +0300 To: Maxim Kokryashkin Message-ID: References: <43adedc2ff4d7894000c986e7469b92a32cf69ba.1673534407.git.imun@tarantool.org> <1673566064.971611960@f475.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1673566064.971611960@f475.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90D1502B3BE350FE4AC552EA4D558FC47A948DB6F48C8D1CF00894C459B0CD1B928D91B4B3E43FD42E92E396D65646320BE2F121EF32A4E74C5BACA9C609EAB2D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372D850D7477D401F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85755255FBAD0F9687D6C216E39ACF224117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC1BE95B8C87527B4BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520599709FD55CB46A628451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EED76C6ED7039589DEFCB1554B277F7060D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE56136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BC478629CBEC79DEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D62FF052C6BF7E452B51FFFDF55E09CB75B48F8573166CE5821E50FFF9388F189CF1D7E09C32AA3244C9BB9404B8A4ECB8984065AA412B0B2B0CE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojI459hkOkW/aV89I59pdc/w== X-Mailru-Sender: F16D9CAFEEA6770E7B6EAD4ADB3BCAF0A41D82613EEFF95BE59AC4DD0A4DA6DAF31FE319BF0A92C9F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! Nice to see matrix in integrational workflow! LGTM, with a single nit below. On 13.01.23, Maxim Kokryashkin wrote: > > Hi! > Thanks for the patch! > LGTM, except for a few nits below. > >  > >>Considering the changes made in scope of the previous commit, it has Typo: s/scope/the scope/ > >>been decided to dispatch LuaJIT integration testing to the runner the > >>similar way (i.e. by using the pair of + > >>values). As a result a new job with quite similar strategy matrix[1] is > >>added as a successor for job. The new job uses the new > >>version (with and parameters introduced and > >>optional obsolete parameter) of LuaJIT integration > >Typo: s/optional/the optional/ > >Typo: s/of LuaJIT/of the LuaJIT/ > >>workflow from tarantool/tarantool repo. > >Typo: s/from/from the/ > >> > >>[1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow > >> > >>Signed-off-by: Igor Munkin < imun@tarantool.org > > >>--- > >> .github/workflows/testing.yml | 190 ++++++---------------------------- > >> 1 file changed, 30 insertions(+), 160 deletions(-) > >> > >>diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml > >>index 5558e3ea..d707ce83 100644 > >>--- a/.github/workflows/testing.yml > >>+++ b/.github/workflows/testing.yml > >>2.34.0 > >-- > >Best regards, > >Maxim Kokryashkin -- Best regards, Sergey Kaplun