Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing
Date: Thu, 12 Jan 2023 17:51:36 +0300	[thread overview]
Message-ID: <db710bb648c8d034a1976249b9edffc8588e2bb7.1673534407.git.imun@tarantool.org> (raw)
In-Reply-To: <cover.1673534407.git.imun@tarantool.org>

Before the patch the all LuaJIT testing jobs were dispatched to the
runner with the name given via strategy matrix <RUNNER> entry. However,
more convenient way for dispatching is the triplet of the following
labels:
* <matrix.ARCH> to specify the host architecture (i.e. x86_64 or ARM64)
* <matrix.OS> to specify the OS family name (either Linux or macOS)
* 'self-hosted' to make job dispatch only to the runners from Tarantool
  ghacts-shared-* pool and never choose GitHub public resources.

With the given triplet the proper runner is chosen for the particular
testing flavor.

Moreover, the new 'lightweight' and 'regular' labels are also used in
<runs-on> list, since the new "lightweight" runners have been introduced
to ghacts-shared-* pool. There are a couple of LuaJIT tests that
requires more memory than provided by "lightweight" runners, so only
"regular" ones need to be chosen for full LuaJIT testing. At the same
time there is no need to use "regular" runner for LuaJIT Static analysis
workflow, hence 'lightweight' label is added to <runs-on> list in
lint.yml workflow file.

Signed-off-by: Igor Munkin <imun@tarantool.org>
---
 .github/workflows/gnumake-builds-testing.yml | 20 ++------------------
 .github/workflows/lint.yml                   |  2 +-
 .github/workflows/testing.yml                | 20 ++------------------
 3 files changed, 5 insertions(+), 37 deletions(-)

diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
index ad9d5015..e5f82780 100644
--- a/.github/workflows/gnumake-builds-testing.yml
+++ b/.github/workflows/gnumake-builds-testing.yml
@@ -38,22 +38,6 @@ jobs:
         GC64: [ON, OFF]
         OS: [Linux, macOS]
         include:
-          - ARCH: ARM64
-            OS: Linux
-            NAME: Linux/aarch64
-            RUNNER: graviton
-          - ARCH: x86_64
-            OS: Linux
-            NAME: Linux/x86_64
-            RUNNER: ubuntu-20.04-self-hosted
-          - ARCH: ARM64
-            OS: macOS
-            NAME: macOS/M1
-            RUNNER: macos-11-m1
-          - ARCH: x86_64
-            OS: macOS
-            NAME: macOS/x86_64
-            RUNNER: macos-11
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
             MAKEBUILDFLAGS: -DLUA_USE_ASSERT -DLUA_USE_APICHECK
@@ -70,10 +54,10 @@ jobs:
             GC64: OFF
           - OS: macOS
             GC64: OFF
-    runs-on: [self-hosted, '${{ matrix.RUNNER }}']
+    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
     name: >
       LuaJIT
-      (${{ matrix.NAME }})
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e565144c..02150922 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -30,7 +30,7 @@ concurrency:
 
 jobs:
   test-luacheck:
-    runs-on: ubuntu-20.04-self-hosted
+    runs-on: [self-hosted, lightweight, Linux, x86_64]
     name: luacheck
     steps:
       - uses: actions/checkout@v2.3.4
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index 958f8e27..5558e3ea 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -38,22 +38,6 @@ jobs:
         GC64: [ON, OFF]
         OS: [Linux, macOS]
         include:
-          - ARCH: ARM64
-            OS: Linux
-            NAME: Linux/aarch64
-            RUNNER: graviton
-          - ARCH: x86_64
-            OS: Linux
-            NAME: Linux/x86_64
-            RUNNER: ubuntu-20.04-self-hosted
-          - ARCH: ARM64
-            OS: macOS
-            NAME: macOS/M1
-            RUNNER: macos-11-m1
-          - ARCH: x86_64
-            OS: macOS
-            NAME: macOS/x86_64
-            RUNNER: macos-11
           - BUILDTYPE: Debug
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
           - BUILDTYPE: Release
@@ -63,10 +47,10 @@ jobs:
             GC64: OFF
           - OS: macOS
             GC64: OFF
-    runs-on: [self-hosted, '${{ matrix.RUNNER }}']
+    runs-on: [self-hosted, regular, '${{ matrix.OS }}', '${{ matrix.ARCH }}']
     name: >
       LuaJIT
-      (${{ matrix.NAME }})
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
       ${{ matrix.BUILDTYPE }}
       GC64:${{ matrix.GC64 }}
     steps:
-- 
2.34.0


  reply	other threads:[~2023-01-12 15:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 14:51 [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` Igor Munkin via Tarantool-patches [this message]
2023-01-12 23:23   ` [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:10     ` Sergey Kaplun via Tarantool-patches
2023-01-16  7:55       ` Igor Munkin via Tarantool-patches
2023-01-16 12:34         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:53     ` Igor Munkin via Tarantool-patches
2023-01-12 14:51 ` [Tarantool-patches] [PATCH luajit 2/2] ci: use strategy matrix for integration workflow Igor Munkin via Tarantool-patches
2023-01-12 23:27   ` Maxim Kokryashkin via Tarantool-patches
2023-01-13  7:16     ` Sergey Kaplun via Tarantool-patches
2023-01-16  8:00       ` Igor Munkin via Tarantool-patches
2023-01-16 12:35         ` Maxim Kokryashkin via Tarantool-patches
2023-01-16  7:58     ` Igor Munkin via Tarantool-patches
2023-01-18  9:24 ` [Tarantool-patches] [PATCH luajit 0/2] More enhancements in LuaJIT CI Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db710bb648c8d034a1976249b9edffc8588e2bb7.1673534407.git.imun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] ci: change runner dispatch for LuaJIT testing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox