Re: [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

22.01.2021 16:26, Cyrill Gorcunov пишет:
> When operating with bitfields it is a way better
> to use opencoded operations instead of some helpers
> which allow to modify one bit at once.
>
> In the series we drop usage of txn_X_flag(), this
> shrinks code a bit and make possible to test a set
> of bits at once.
>
> issue https://github.com/tarantool/tarantool/issues/5128
> branch gorcunov/gh-5128-txn-flags
>
> Cyrill Gorcunov (6):
>    txn: convert flags to explicit bitfield
>    txn: stop using txn_set_flag
>    test/unit: snap_quorum_delay -- stop using txn_set_flag
>    txn: stop using txn_clear_flag
>    txn: stop using txn_has_flag
>    txn: drop unused txn_x_flag helpers
>
>   src/box/applier.cc             |  4 +--
>   src/box/memtx_engine.c         |  2 +-
>   src/box/txn.c                  | 54 ++++++++++++++++------------------
>   src/box/txn.h                  | 36 ++++++-----------------
>   src/box/txn_limbo.c            | 35 ++++++++++------------
>   test/unit/snap_quorum_delay.cc |  3 +-
>   6 files changed, 55 insertions(+), 79 deletions(-)
>
>
> base-commit: a6fd00ab73705c3afb03b2828526c7b1dfceda08

Hi! Thanks for the patchset!
LGTM.

-- 
Serge Petrenko