From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9C41870310; Wed, 27 Jan 2021 15:08:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9C41870310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611749330; bh=7fdyZTqMDEPiGu0dcB1ILou6twpkBHpSa96xpJ0pF1s=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NilxArP+1wkI2ZqhGrAQTxmBoXy6ttxpvkuuaJVoj1WUF7pZHQtFTMyP9ebHdjf9t 1NsVHOxZ+jf2yovQKnEIu5zo22h79Dju5477cnpg0hofUxGMw96efRgexSHtxcEivE 7Ceiv6rZIyJGKnqFgglsPzVDKDV0mQx2vE4zMY3g= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3402370310 for ; Wed, 27 Jan 2021 15:08:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3402370310 Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1l4jct-0003bP-Nh; Wed, 27 Jan 2021 15:08:48 +0300 To: Cyrill Gorcunov , tml References: <20210122132700.272816-1-gorcunov@gmail.com> Message-ID: <37813e77-e3e9-b80b-28c5-a64157f97dd9@tarantool.org> Date: Wed, 27 Jan 2021 15:08:47 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210122132700.272816-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC9AF79BA1DCC7B756D5389B904F5C05B9800894C459B0CD1B92005AA2078D11EA0FCAF64A721A3A85DD998711590A03C2386091FA637C0ECF9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71840AE9AFD3F5D61C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE78720DE0E0AF9087AEA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C12E5B48C89CF7995C0AC2E35AB67D028279DBA6190E3E0F59FA2833FD35BB23D9E625A9149C048EE1E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B47272755C61AA17BA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCC4C0EF34BD796ECE3AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637E79648063B797253D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CCB718973C3B1084593EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B6D479A90A4652661D089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A535F3C3EC36A8506F9BEC6013E930E1C24ECEECCBD97C32DCD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E24AEBA135C7FA0F221B03817C17DBF930A8783AD6069DB1CD8002BCDEE61F88751D7E09C32AA3244CC018903C77C04D4C72F174795E6E3F71C86C126E7119A0FE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5ZUBkD5pAd+36oH72btG0A== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC1E07FC15BCCE8C7BBC00802D46821675A00D963F346968D73823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 22.01.2021 16:26, Cyrill Gorcunov пишет: > When operating with bitfields it is a way better > to use opencoded operations instead of some helpers > which allow to modify one bit at once. > > In the series we drop usage of txn_X_flag(), this > shrinks code a bit and make possible to test a set > of bits at once. > > issue https://github.com/tarantool/tarantool/issues/5128 > branch gorcunov/gh-5128-txn-flags > > Cyrill Gorcunov (6): > txn: convert flags to explicit bitfield > txn: stop using txn_set_flag > test/unit: snap_quorum_delay -- stop using txn_set_flag > txn: stop using txn_clear_flag > txn: stop using txn_has_flag > txn: drop unused txn_x_flag helpers > > src/box/applier.cc | 4 +-- > src/box/memtx_engine.c | 2 +- > src/box/txn.c | 54 ++++++++++++++++------------------ > src/box/txn.h | 36 ++++++----------------- > src/box/txn_limbo.c | 35 ++++++++++------------ > test/unit/snap_quorum_delay.cc | 3 +- > 6 files changed, 55 insertions(+), 79 deletions(-) > > > base-commit: a6fd00ab73705c3afb03b2828526c7b1dfceda08 Hi! Thanks for the patchset! LGTM. -- Serge Petrenko