Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers
Date: Fri, 22 Jan 2021 16:26:54 +0300	[thread overview]
Message-ID: <20210122132700.272816-1-gorcunov@gmail.com> (raw)

When operating with bitfields it is a way better
to use opencoded operations instead of some helpers
which allow to modify one bit at once.

In the series we drop usage of txn_X_flag(), this
shrinks code a bit and make possible to test a set
of bits at once.

issue https://github.com/tarantool/tarantool/issues/5128
branch gorcunov/gh-5128-txn-flags

Cyrill Gorcunov (6):
  txn: convert flags to explicit bitfield
  txn: stop using txn_set_flag
  test/unit: snap_quorum_delay -- stop using txn_set_flag
  txn: stop using txn_clear_flag
  txn: stop using txn_has_flag
  txn: drop unused txn_x_flag helpers

 src/box/applier.cc             |  4 +--
 src/box/memtx_engine.c         |  2 +-
 src/box/txn.c                  | 54 ++++++++++++++++------------------
 src/box/txn.h                  | 36 ++++++-----------------
 src/box/txn_limbo.c            | 35 ++++++++++------------
 test/unit/snap_quorum_delay.cc |  3 +-
 6 files changed, 55 insertions(+), 79 deletions(-)


base-commit: a6fd00ab73705c3afb03b2828526c7b1dfceda08
-- 
2.29.2


             reply	other threads:[~2021-01-22 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 13:26 Cyrill Gorcunov via Tarantool-patches [this message]
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 1/6] txn: convert flags to explicit bitfield Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 2/6] txn: stop using txn_set_flag Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 3/6] test/unit: snap_quorum_delay -- " Cyrill Gorcunov via Tarantool-patches
2021-01-30 19:17   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-31 10:40     ` Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 4/6] txn: stop using txn_clear_flag Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 5/6] txn: stop using txn_has_flag Cyrill Gorcunov via Tarantool-patches
2021-01-30 19:17   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-31 22:13     ` Cyrill Gorcunov via Tarantool-patches
2021-02-03 19:47       ` Vladislav Shpilevoy via Tarantool-patches
2021-02-03 22:02         ` Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:27 ` [Tarantool-patches] [PATCH 6/6] txn: drop unused txn_x_flag helpers Cyrill Gorcunov via Tarantool-patches
2021-01-27 12:08 ` [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers Serge Petrenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122132700.272816-1-gorcunov@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox