From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 5/6] txn: stop using txn_has_flag
Date: Sat, 30 Jan 2021 20:17:59 +0100 [thread overview]
Message-ID: <a87bdbe9-eb93-4775-7d80-7831420b2f8b@tarantool.org> (raw)
In-Reply-To: <20210122132700.272816-6-gorcunov@gmail.com>
Thanks for the patch!
On 22.01.2021 14:26, Cyrill Gorcunov wrote:
> Part-of #5128
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/box/txn.c | 39 +++++++++++++++++++--------------------
> src/box/txn.h | 2 +-
> src/box/txn_limbo.c | 26 +++++++++++++-------------
> 3 files changed, 33 insertions(+), 34 deletions(-)
>
> diff --git a/src/box/txn.c b/src/box/txn.c
> index 6197cf012..d1964b5f7 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -526,7 +526,7 @@ txn_free_or_wakeup(struct txn *txn)
> void
> txn_complete_fail(struct txn *txn)
> {
> - assert(!txn_has_flag(txn, TXN_IS_DONE));
> + assert(!(txn->flags & TXN_IS_DONE));
Please, use explicit != 0. We don't apply '!' operator to
non-boolean values. The same in other places. This I can even
find in the code style guide:
https://github.com/tarantool/tarantool/wiki/Code-review-procedure#code-style
next prev parent reply other threads:[~2021-01-30 19:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 13:26 [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 1/6] txn: convert flags to explicit bitfield Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 2/6] txn: stop using txn_set_flag Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 3/6] test/unit: snap_quorum_delay -- " Cyrill Gorcunov via Tarantool-patches
2021-01-30 19:17 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-31 10:40 ` Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 4/6] txn: stop using txn_clear_flag Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:26 ` [Tarantool-patches] [PATCH 5/6] txn: stop using txn_has_flag Cyrill Gorcunov via Tarantool-patches
2021-01-30 19:17 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-31 22:13 ` Cyrill Gorcunov via Tarantool-patches
2021-02-03 19:47 ` Vladislav Shpilevoy via Tarantool-patches
2021-02-03 22:02 ` Cyrill Gorcunov via Tarantool-patches
2021-01-22 13:27 ` [Tarantool-patches] [PATCH 6/6] txn: drop unused txn_x_flag helpers Cyrill Gorcunov via Tarantool-patches
2021-01-27 12:08 ` [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87bdbe9-eb93-4775-7d80-7831420b2f8b@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 5/6] txn: stop using txn_has_flag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox