From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DD5B17030F; Fri, 22 Jan 2021 16:27:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD5B17030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611322028; bh=UuMw3ntizp8yNU2zSwioASgEPOUszDeWSmm1V+Iu2c8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Z82eNhEX++6Y2kTzwdShtwqyQzdX6URDagnVLFa2v8acg30WJZ22PeHLRlAT/a4t3 5sNQrkGQ9bwxiqKxDxV9TqPi7Poo2YucwAqsu6ETXkogv5pGxd7Qd15erkHD6S/qop o+fvc/4c/99/YLJGs4manBzPSJ5kaeXYp3rOOmvI= Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9492A7030F for ; Fri, 22 Jan 2021 16:27:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9492A7030F Received: by mail-lj1-f181.google.com with SMTP id j3so6501270ljb.9 for ; Fri, 22 Jan 2021 05:27:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UMcakcWQZ/KcI/Hzvm+jCdxwjBvYGNQYj/rNTNsLlPw=; b=n2hUWdTwgF+bcisJB7r02jfdeeKxFW2KCodDchyrlVhCByW1Au1F9QJG6u5hMrSKiR vAGi8xl58G3/onQDlmsmQwydwcqLcNZUqpnPxPlHsN/Ou3sx/mC46HtLj13iwGY8801V tNOyIOfYuG5N8TxiBK01yWiBm40YInUsbCBxoa8m0NAS1IRiZTP5ueFLZip19OS6Xm2Y zJ8VjGk26aH6cT9ijIR8DeM2SdoWiZ7bkXpCrUba2jHjViTk1aWal+t56U/j9KpDku3h AT6RT4rbdShe4zsxrmCCofpwWW8C8u+4scBRp2uAF1dXdbdfNqFa8+Uxk8d9qBPhs9Tv Rq2A== X-Gm-Message-State: AOAM533/p9M4ncz97B9LvFOA7cuZqiHmNtkrcDZH0ETTHEaggcDbG9o4 6FAsam8ZGHjtp7P6bSWCSsE9j8GxzEM= X-Google-Smtp-Source: ABdhPJyRVnSW/wnThojfmaCpdzmwRbwfCRK4acvVxhtaH7IH+yCazrQ0nDiOa2AYBnE/b/XkBkQpOQ== X-Received: by 2002:a2e:81d1:: with SMTP id s17mr142413ljg.49.1611322026544; Fri, 22 Jan 2021 05:27:06 -0800 (PST) Received: from grain.localdomain ([5.18.91.94]) by smtp.gmail.com with ESMTPSA id n25sm883015lfh.177.2021.01.22.05.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:27:05 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 98BBA5601B1; Fri, 22 Jan 2021 16:27:04 +0300 (MSK) To: tml Date: Fri, 22 Jan 2021 16:26:54 +0300 Message-Id: <20210122132700.272816-1-gorcunov@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/6] txn: drop txn_X_flag helpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" When operating with bitfields it is a way better to use opencoded operations instead of some helpers which allow to modify one bit at once. In the series we drop usage of txn_X_flag(), this shrinks code a bit and make possible to test a set of bits at once. issue https://github.com/tarantool/tarantool/issues/5128 branch gorcunov/gh-5128-txn-flags Cyrill Gorcunov (6): txn: convert flags to explicit bitfield txn: stop using txn_set_flag test/unit: snap_quorum_delay -- stop using txn_set_flag txn: stop using txn_clear_flag txn: stop using txn_has_flag txn: drop unused txn_x_flag helpers src/box/applier.cc | 4 +-- src/box/memtx_engine.c | 2 +- src/box/txn.c | 54 ++++++++++++++++------------------ src/box/txn.h | 36 ++++++----------------- src/box/txn_limbo.c | 35 ++++++++++------------ test/unit/snap_quorum_delay.cc | 3 +- 6 files changed, 55 insertions(+), 79 deletions(-) base-commit: a6fd00ab73705c3afb03b2828526c7b1dfceda08 -- 2.29.2