Re: [Tarantool-patches] [PATCH luajit v3 00/29] Adapt PUC-Rio Lua 5.1 test suite

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for the new series! Now everything LGTM.

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master.

On 13.04.21, Sergey Kaplun wrote:
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2
> Test branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2
> 
> Side note: CI is red due to
> https://github.com/tarantool/tarantool/issues/5986.
> 
> Issues:
> * https://github.com/tarantool/tarantool/issues/5845
> * https://github.com/tarantool/tarantool/issues/4473
> 
> Suite is taken intact exept trailing whitespaces.
> Command to check:
> | $ diff -ruZ --color ../test/PUC-Lua-5.1-tests/ ~/Downloads/lua5.1-tests/
> | Only in ../test/PUC-Lua-5.1-tests/: CMakeLists.txt
> | Only in ../test/PUC-Lua-5.1-tests/libs: CMakeLists.txt
> | Only in ~/Downloads/lua5.1-tests/libs: makefile
> | Only in ~/Downloads/lua5.1-tests/libs: P1
> 
> Changes in the v2:
> * split commits to atomic changes
> * more verbose comments for some tests
> * some test fixed instead commenting
> 
> Changes in the v3:
> * more verbose comments and commit messages
> * PUC-Lua-5.1-tests -> PUC-Rio-Lua-5.1-tests
> * squash commits for vararg functions
> * move "LuaJIT:" tag to the top of comments
> * introduce _dofile and _loadfile functions for PUC-Rio-Lua-5.1 suite
>   and create <luajit-tests-init.lua> test prerunner to set up them
>   correctly for out-of-source build.
> 
> 
> Sergey Kaplun (29):
>   test: add PUC-Rio Lua 5.1 test suite
>   test: build auxiliary C libs from PUC-Rio Lua 5.1
>   test: adapt PUC-Rio suite for out-of-source build
>   test: remove quotes in progname from PUC-Rio
>   test: adapt PUC-Rio test for arg presence
>   test: disable PUC-Rio tests confused by -v output
>   test: disable PUC-Rio tests for bytecode header
>   test: adapt PUC-Rio tests counting GC steps
>   test: disable PUC-Rio suite tests for line hook
>   test: adapt PUC-Rio tests with vararg functions
>   test: adapt PUC-Rio test for debug in vararg func
>   test: adapt PUC-Rio test with count hooks
>   test: disable PUC-Rio test for tail call info
>   test: adapt PUC-Rio test with activeline check
>   test: disable PUC-Rio test for per-coroutine hooks
>   test: adapt PUC-Rio test for %q in string.format
>   test: disable locale-dependent PUC-Rio tests
>   test: use math.fmod in PUC-Rio tests
>   test: remove string.gfind assert in PUC-Rio test
>   test: disable PUC-Rio test for getfenv in tailcall
>   test: disable PUC-Rio test for variables in error
>   test: disable PUC-Rio test for fast function name
>   test: disable PUC-Rio test for non-asci identifier
>   test: disable PUC-Rio test for syntax level error
>   test: disable PUC-RIO tests for several -l options
>   test: disable PUC-Rio test for checking arg layout
>   test: disable PUC-Rio test checking -h option
>   test: disable PUC-Rio hanging GC test
>   test: disable too deep recursive PUC-Rio test
> 

<snipped>

> 
> -- 
> 2.31.0
> 

-- 
Best regards,
IM