From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9FA256EC5F; Thu, 15 Apr 2021 00:09:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9FA256EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618434540; bh=aOI83mPJLTjDsT0I1XxMleZYSZCZB2EiL3f7tNPB5N0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Pjedz4HkCURoa51sNcd/brZ2fwfaR5tuN2Kx0QBk9/gHv8/E8u+WxyaA6RhZhDSo3 MObTUoD2dPokJtxzgZEcU6Vq2bpzRHw5fE6ox7LfHuq38DFNaXGrNl+A2aZ/e1r2Q8 hFQcz+kM99km6MuRmorU66pAWMUOxpNxgilVxAHU= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B831C6EC5F for ; Thu, 15 Apr 2021 00:08:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B831C6EC5F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lWmks-0007lL-M0; Thu, 15 Apr 2021 00:08:59 +0300 Date: Thu, 15 Apr 2021 00:08:46 +0300 To: Sergey Kaplun Message-ID: <20210414210846.GB29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D0F00AE41BB9A5343182A05F538085040F060AB45D296401B9CAFC26320EDB6D1B5731257087AA64A68CEF4444B808B8D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7876E9C5582D2D91DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370EBB47D88F71BB738638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B22235E909AE600DE27454DE500CD59948AA867293B0326636D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE493B89ED3C7A6281781DC7F9DB2523BC7CDC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319AF152DD53D487CAD3DF300CDFC134A3 X-C1DE0DAB: 0D63561A33F958A56DFDA2C504321242374FC029207EF6DFAE7F918180E4D71AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F343DA43F62289F137138DA2A968089B2673B230C68F0C84F8D3C2EB0A2DB628200C249A273B7151D7E09C32AA3244C9B842A4BC8AC756CB381411D67DCCE63B038C9161EF167A1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDumRqM1hrm36aA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822710D67C466D13022EDE75EFBB6935A88A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 00/29] Adapt PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the new series! Now everything LGTM. I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master. On 13.04.21, Sergey Kaplun wrote: > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2 > Test branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2 > > Side note: CI is red due to > https://github.com/tarantool/tarantool/issues/5986. > > Issues: > * https://github.com/tarantool/tarantool/issues/5845 > * https://github.com/tarantool/tarantool/issues/4473 > > Suite is taken intact exept trailing whitespaces. > Command to check: > | $ diff -ruZ --color ../test/PUC-Lua-5.1-tests/ ~/Downloads/lua5.1-tests/ > | Only in ../test/PUC-Lua-5.1-tests/: CMakeLists.txt > | Only in ../test/PUC-Lua-5.1-tests/libs: CMakeLists.txt > | Only in ~/Downloads/lua5.1-tests/libs: makefile > | Only in ~/Downloads/lua5.1-tests/libs: P1 > > Changes in the v2: > * split commits to atomic changes > * more verbose comments for some tests > * some test fixed instead commenting > > Changes in the v3: > * more verbose comments and commit messages > * PUC-Lua-5.1-tests -> PUC-Rio-Lua-5.1-tests > * squash commits for vararg functions > * move "LuaJIT:" tag to the top of comments > * introduce _dofile and _loadfile functions for PUC-Rio-Lua-5.1 suite > and create test prerunner to set up them > correctly for out-of-source build. > > > Sergey Kaplun (29): > test: add PUC-Rio Lua 5.1 test suite > test: build auxiliary C libs from PUC-Rio Lua 5.1 > test: adapt PUC-Rio suite for out-of-source build > test: remove quotes in progname from PUC-Rio > test: adapt PUC-Rio test for arg presence > test: disable PUC-Rio tests confused by -v output > test: disable PUC-Rio tests for bytecode header > test: adapt PUC-Rio tests counting GC steps > test: disable PUC-Rio suite tests for line hook > test: adapt PUC-Rio tests with vararg functions > test: adapt PUC-Rio test for debug in vararg func > test: adapt PUC-Rio test with count hooks > test: disable PUC-Rio test for tail call info > test: adapt PUC-Rio test with activeline check > test: disable PUC-Rio test for per-coroutine hooks > test: adapt PUC-Rio test for %q in string.format > test: disable locale-dependent PUC-Rio tests > test: use math.fmod in PUC-Rio tests > test: remove string.gfind assert in PUC-Rio test > test: disable PUC-Rio test for getfenv in tailcall > test: disable PUC-Rio test for variables in error > test: disable PUC-Rio test for fast function name > test: disable PUC-Rio test for non-asci identifier > test: disable PUC-Rio test for syntax level error > test: disable PUC-RIO tests for several -l options > test: disable PUC-Rio test for checking arg layout > test: disable PUC-Rio test checking -h option > test: disable PUC-Rio hanging GC test > test: disable too deep recursive PUC-Rio test > > > -- > 2.31.0 > -- Best regards, IM