From: Kirill Yukhin <kyukhin@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: mons@tarantool.org, tarantool-patches@dev.tarantool.org,
v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting
Date: Fri, 25 Dec 2020 08:29:31 +0000 [thread overview]
Message-ID: <20201225082931.fln3sud6n22qe7w3@tarantool.org> (raw)
In-Reply-To: <0e1d128e4f2eed0f0858dbfb6cb012de52baa4e6.1608816289.git.sergepetrenko@tarantool.org>
Hello,
On 24 Dec 16:34, Serge Petrenko via Tarantool-patches wrote:
> Report box.stat().*.total, box.stat.net().*.total and
> box.stat.net().*.current via feedback daemon report.
> Accompany this data with the time when report was generated so that it's
> possible to calculate RPS from this data on the feedback server.
>
> `box.stat().OP_NAME.total` reside in `feedback.stats.box.OP_NAME.total`, while
> `box.stat.net().OP_NAME.total` reside in `feedback.stats.net.OP_NAME.total`
> The time of report generation is located at `feedback.stats.time`
>
> Closes #5589
> ---
> src/box/lua/feedback_daemon.lua | 29 +++++++++++++++-
> test/box-tap/feedback_daemon.test.lua | 49 ++++++++++++++++++++++++++-
> 2 files changed, 76 insertions(+), 2 deletions(-)
I've checked your patch into master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-12-25 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 13:34 [Tarantool-patches] [PATCH 0/2] feedback_daemon: add operation statistics reporting and an additional report on shutdown Serge Petrenko
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting Serge Petrenko
2020-12-24 17:54 ` Vladislav Shpilevoy
2020-12-24 21:09 ` Serge Petrenko
2020-12-25 8:13 ` Aleksandr Lyapunov
2020-12-25 8:29 ` Kirill Yukhin [this message]
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit Serge Petrenko
2020-12-24 17:54 ` Vladislav Shpilevoy
2020-12-24 21:11 ` Serge Petrenko
2020-12-25 8:12 ` Aleksandr Lyapunov
2020-12-25 8:50 ` Serge Petrenko
2020-12-25 11:23 ` Aleksandr Lyapunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201225082931.fln3sud6n22qe7w3@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=mons@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox