Tarantool development patches archive
 help / color / mirror / Atom feed
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
	v.shpilevoy@tarantool.org, mons@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit
Date: Fri, 25 Dec 2020 14:23:49 +0300	[thread overview]
Message-ID: <a8cbb422-86eb-b2ad-e0da-6b8b3bb5c125@tarantool.org> (raw)
In-Reply-To: <4fc3e2cc-07f2-32c0-5311-b2243227527e@tarantool.org>


> I may be mistaken, but as far as I understand, channel:put calls 
> fiber_wakeup()
> under the hood. And fiber_wakeup() puts the fiber to execution at the 
> end of this particular
> event loop iteration.
>
> The next on_shutdown trigger breaks the event loop though. And I'm not 
> sure whether
> it does it immediately or waits till the event loop iteration end.
>
> Here's what the libev doc says:
> `
> ev_break (loop, how)
>
>    Can be used to make a call to|ev_run|return early (but only after it
>    has processed all outstanding events).
>
> `
> Looks like we're safe. The loop won't break until it processes the 
> fiber_wakeup event.

Looks like you are right. But I feel uncomfortable when I rely on 
feature that is
not documented and/or not covered with tests.

      reply	other threads:[~2020-12-25 11:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 13:34 [Tarantool-patches] [PATCH 0/2] feedback_daemon: add operation statistics reporting and an additional report on shutdown Serge Petrenko
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting Serge Petrenko
2020-12-24 17:54   ` Vladislav Shpilevoy
2020-12-24 21:09     ` Serge Petrenko
2020-12-25  8:13       ` Aleksandr Lyapunov
2020-12-25  8:29   ` Kirill Yukhin
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit Serge Petrenko
2020-12-24 17:54   ` Vladislav Shpilevoy
2020-12-24 21:11     ` Serge Petrenko
2020-12-25  8:12   ` Aleksandr Lyapunov
2020-12-25  8:50     ` Serge Petrenko
2020-12-25 11:23       ` Aleksandr Lyapunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8cbb422-86eb-b2ad-e0da-6b8b3bb5c125@tarantool.org \
    --to=alyapunov@tarantool.org \
    --cc=mons@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox