Tarantool development patches archive
 help / color / mirror / Atom feed
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	mons@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting
Date: Fri, 25 Dec 2020 11:13:15 +0300	[thread overview]
Message-ID: <d9cb1f8c-7dcf-0d0f-05ba-0d51f184523c@tarantool.org> (raw)
In-Reply-To: <8c063c6d-50e6-07bc-a9d4-98e805176ee6@tarantool.org>

Hi, thanks for the patch!

1/2 - LGTM!

On 25.12.2020 00:09, Serge Petrenko wrote:
>
>
> 24.12.2020 20:54, Vladislav Shpilevoy пишет:
>> Hi! Thanks for the patch!
>>
>> Consider this diff which I pushed as a separate commit
>> in your branch:
>
> Thanks for the review!
>
> I applied your diff.
>
> Sorry you had to fix indentation for me.
>
>>
>> ====================
>> diff --git a/src/box/lua/feedback_daemon.lua 
>> b/src/box/lua/feedback_daemon.lua
>> index 1aac32bb3..07f114aea 100644
>> --- a/src/box/lua/feedback_daemon.lua
>> +++ b/src/box/lua/feedback_daemon.lua
>> @@ -285,7 +285,7 @@ local function fill_in_options(feedback)
>>   end
>>     local function fill_in_stats(feedback)
>> -    local stats = {box={}, net={}}
>> +    local stats = {box = {}, net = {}}
>>       local box_stat = box.stat()
>>       local net_stat = box.stat.net()
>>   @@ -300,11 +300,12 @@ local function fill_in_stats(feedback)
>>       end
>>       -- Send box.stat.net().*.total and box.stat.net().*.current.
>>       for val, tbl in pairs(net_stat) do
>> -        if type(tbl) == 'table' and (tbl.total ~= nil or tbl.current 
>> ~= nil) then
>> -                    stats.net[val] = {
>> -                        total = tbl.total,
>> -                        current = tbl.current
>> -                    }
>> +        if type(tbl) == 'table' and
>> +           (tbl.total ~= nil or tbl.current ~= nil) then
>> +            stats.net[val] = {
>> +                total = tbl.total,
>> +                current = tbl.current
>> +            }
>>           end
>>       end
>>       feedback.stats = stats
>

  reply	other threads:[~2020-12-25  8:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 13:34 [Tarantool-patches] [PATCH 0/2] feedback_daemon: add operation statistics reporting and an additional report on shutdown Serge Petrenko
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting Serge Petrenko
2020-12-24 17:54   ` Vladislav Shpilevoy
2020-12-24 21:09     ` Serge Petrenko
2020-12-25  8:13       ` Aleksandr Lyapunov [this message]
2020-12-25  8:29   ` Kirill Yukhin
2020-12-24 13:34 ` [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit Serge Petrenko
2020-12-24 17:54   ` Vladislav Shpilevoy
2020-12-24 21:11     ` Serge Petrenko
2020-12-25  8:12   ` Aleksandr Lyapunov
2020-12-25  8:50     ` Serge Petrenko
2020-12-25 11:23       ` Aleksandr Lyapunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9cb1f8c-7dcf-0d0f-05ba-0d51f184523c@tarantool.org \
    --to=alyapunov@tarantool.org \
    --cc=mons@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox