From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Serge Petrenko <sergepetrenko@tarantool.org>, alyapunov@tarantool.org, mons@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting Date: Thu, 24 Dec 2020 18:54:13 +0100 [thread overview] Message-ID: <c6493f88-5c4a-eaf1-5135-7aa919024562@tarantool.org> (raw) In-Reply-To: <0e1d128e4f2eed0f0858dbfb6cb012de52baa4e6.1608816289.git.sergepetrenko@tarantool.org> Hi! Thanks for the patch! Consider this diff which I pushed as a separate commit in your branch: ==================== diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 1aac32bb3..07f114aea 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -285,7 +285,7 @@ local function fill_in_options(feedback) end local function fill_in_stats(feedback) - local stats = {box={}, net={}} + local stats = {box = {}, net = {}} local box_stat = box.stat() local net_stat = box.stat.net() @@ -300,11 +300,12 @@ local function fill_in_stats(feedback) end -- Send box.stat.net().*.total and box.stat.net().*.current. for val, tbl in pairs(net_stat) do - if type(tbl) == 'table' and (tbl.total ~= nil or tbl.current ~= nil) then - stats.net[val] = { - total = tbl.total, - current = tbl.current - } + if type(tbl) == 'table' and + (tbl.total ~= nil or tbl.current ~= nil) then + stats.net[val] = { + total = tbl.total, + current = tbl.current + } end end feedback.stats = stats
next prev parent reply other threads:[~2020-12-24 17:54 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-24 13:34 [Tarantool-patches] [PATCH 0/2] feedback_daemon: add operation statistics reporting and an additional report on shutdown Serge Petrenko 2020-12-24 13:34 ` [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting Serge Petrenko 2020-12-24 17:54 ` Vladislav Shpilevoy [this message] 2020-12-24 21:09 ` Serge Petrenko 2020-12-25 8:13 ` Aleksandr Lyapunov 2020-12-25 8:29 ` Kirill Yukhin 2020-12-24 13:34 ` [Tarantool-patches] [PATCH 2/2] feedback_daemon: send feedback on tarantool exit Serge Petrenko 2020-12-24 17:54 ` Vladislav Shpilevoy 2020-12-24 21:11 ` Serge Petrenko 2020-12-25 8:12 ` Aleksandr Lyapunov 2020-12-25 8:50 ` Serge Petrenko 2020-12-25 11:23 ` Aleksandr Lyapunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c6493f88-5c4a-eaf1-5135-7aa919024562@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alyapunov@tarantool.org \ --cc=mons@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation statistics reporting' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox