From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C3E434765E0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 25 Dec 2020 11:29:32 +0300 (MSK)
Date: Fri, 25 Dec 2020 08:29:31 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201225082931.fln3sud6n22qe7w3@tarantool.org>
References: <cover.1608816289.git.sergepetrenko@tarantool.org>
 <0e1d128e4f2eed0f0858dbfb6cb012de52baa4e6.1608816289.git.sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0e1d128e4f2eed0f0858dbfb6cb012de52baa4e6.1608816289.git.sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback_daemon: add operation
 statistics reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: mons@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hello,

On 24 Dec 16:34, Serge Petrenko via Tarantool-patches wrote:
> Report box.stat().*.total, box.stat.net().*.total and
> box.stat.net().*.current via feedback daemon report.
> Accompany this data with the time when report was generated so that it's
> possible to calculate RPS from this data on the feedback server.
> 
> `box.stat().OP_NAME.total` reside in `feedback.stats.box.OP_NAME.total`, while
> `box.stat.net().OP_NAME.total` reside in `feedback.stats.net.OP_NAME.total`
> The time of report generation is located at `feedback.stats.time`
> 
> Closes #5589
> ---
>  src/box/lua/feedback_daemon.lua       | 29 +++++++++++++++-
>  test/box-tap/feedback_daemon.test.lua | 49 ++++++++++++++++++++++++++-
>  2 files changed, 76 insertions(+), 2 deletions(-)

I've checked your patch into master.

--
Regards, Kirill Yukhin