[Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua

[Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua

[Alexander V. Tikhonov]

Cc: tarantool-patches@dev.tarantool.org

Added test-run filter on box.snapshot error message:

  'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'

to avoid of printing changing data in results file to be able to use
its checksums in fragile list of test-run to rerun it as flaky issue.

Needed for #4346
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
Issue: https://github.com/tarantool/tarantool/issues/4346

 test/vinyl/errinj.result   | 5 +++++
 test/vinyl/errinj.test.lua | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/test/vinyl/errinj.result b/test/vinyl/errinj.result
index bf49f4e46..6f12e2b4a 100644
--- a/test/vinyl/errinj.result
+++ b/test/vinyl/errinj.result
@@ -10,6 +10,11 @@ fiber = require('fiber')
 errinj = box.error.injection
 ---
 ...
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+---
+- true
+...
 --
 -- Lost data in case of dump error
 --
diff --git a/test/vinyl/errinj.test.lua b/test/vinyl/errinj.test.lua
index 2c8121364..cdc695e1b 100644
--- a/test/vinyl/errinj.test.lua
+++ b/test/vinyl/errinj.test.lua
@@ -2,6 +2,10 @@ test_run = require('test_run').new()
 fio = require('fio')
 fiber = require('fiber')
 errinj = box.error.injection
+
+test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
+             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
+
 --
 -- Lost data in case of dump error
 --
-- 
2.25.1

Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua

[Oleg Koshovetc]

LGTM

NIT:

After concatenation the final command will look like "push filter 
'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'to 'Invalid 
VYLOG file: Slice <NUM> deleted but not registered'" with missing space 
before "to". As far as I am concerned this is still going to be parsed 
correctly, however I would like to see a space there.

On 08.12.2020 19:00, Alexander V. Tikhonov via Tarantool-patches wrote:
> Cc: tarantool-patches@dev.tarantool.org
>
> Added test-run filter on box.snapshot error message:
>
>    'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
>
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
>
> Needed for #4346
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
> Issue: https://github.com/tarantool/tarantool/issues/4346
>
>   test/vinyl/errinj.result   | 5 +++++
>   test/vinyl/errinj.test.lua | 4 ++++
>   2 files changed, 9 insertions(+)
>
> diff --git a/test/vinyl/errinj.result b/test/vinyl/errinj.result
> index bf49f4e46..6f12e2b4a 100644
> --- a/test/vinyl/errinj.result
> +++ b/test/vinyl/errinj.result
> @@ -10,6 +10,11 @@ fiber = require('fiber')
>   errinj = box.error.injection
>   ---
>   ...
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> +             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +---
> +- true
> +...
>   --
>   -- Lost data in case of dump error
>   --
> diff --git a/test/vinyl/errinj.test.lua b/test/vinyl/errinj.test.lua
> index 2c8121364..cdc695e1b 100644
> --- a/test/vinyl/errinj.test.lua
> +++ b/test/vinyl/errinj.test.lua
> @@ -2,6 +2,10 @@ test_run = require('test_run').new()
>   fio = require('fio')
>   fiber = require('fiber')
>   errinj = box.error.injection
> +
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> +             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +
>   --
>   -- Lost data in case of dump error
>   --

Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua

[Kirill Yukhin]

Hello,

On 08 Dec 19:00, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Added test-run filter on box.snapshot error message:
> 
>   'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
> 
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
> 
> Needed for #4346
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
> Issue: https://github.com/tarantool/tarantool/issues/4346

LGTM.
I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin