Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua
Date: Fri, 11 Dec 2020 09:17:39 +0000	[thread overview]
Message-ID: <20201211091739.y3q7ihel6qgodequ@tarantool.org> (raw)
In-Reply-To: <83b8e393ad82dd9eb40271b62bb1258ad72cee38.1607443162.git.avtikhon@tarantool.org>

Hello,

On 08 Dec 19:00, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Added test-run filter on box.snapshot error message:
> 
>   'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
> 
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
> 
> Needed for #4346
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
> Issue: https://github.com/tarantool/tarantool/issues/4346

LGTM.
I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2020-12-11  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 16:00 Alexander V. Tikhonov
2020-12-10 15:28 ` Oleg Koshovetc
2020-12-11  9:17 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211091739.y3q7ihel6qgodequ@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox