From: Oleg Koshovetc <okoshovetc@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua
Date: Thu, 10 Dec 2020 18:28:27 +0300 [thread overview]
Message-ID: <e389ec04-fbb5-8063-d334-1e8208853b14@tarantool.org> (raw)
In-Reply-To: <83b8e393ad82dd9eb40271b62bb1258ad72cee38.1607443162.git.avtikhon@tarantool.org>
LGTM
NIT:
After concatenation the final command will look like "push filter
'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'to 'Invalid
VYLOG file: Slice <NUM> deleted but not registered'" with missing space
before "to". As far as I am concerned this is still going to be parsed
correctly, however I would like to see a space there.
On 08.12.2020 19:00, Alexander V. Tikhonov via Tarantool-patches wrote:
> Cc: tarantool-patches@dev.tarantool.org
>
> Added test-run filter on box.snapshot error message:
>
> 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
>
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
>
> Needed for #4346
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
> Issue: https://github.com/tarantool/tarantool/issues/4346
>
> test/vinyl/errinj.result | 5 +++++
> test/vinyl/errinj.test.lua | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/test/vinyl/errinj.result b/test/vinyl/errinj.result
> index bf49f4e46..6f12e2b4a 100644
> --- a/test/vinyl/errinj.result
> +++ b/test/vinyl/errinj.result
> @@ -10,6 +10,11 @@ fiber = require('fiber')
> errinj = box.error.injection
> ---
> ...
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> + "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +---
> +- true
> +...
> --
> -- Lost data in case of dump error
> --
> diff --git a/test/vinyl/errinj.test.lua b/test/vinyl/errinj.test.lua
> index 2c8121364..cdc695e1b 100644
> --- a/test/vinyl/errinj.test.lua
> +++ b/test/vinyl/errinj.test.lua
> @@ -2,6 +2,10 @@ test_run = require('test_run').new()
> fio = require('fio')
> fiber = require('fiber')
> errinj = box.error.injection
> +
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> + "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +
> --
> -- Lost data in case of dump error
> --
next prev parent reply other threads:[~2020-12-10 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 16:00 Alexander V. Tikhonov
2020-12-10 15:28 ` Oleg Koshovetc [this message]
2020-12-11 9:17 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e389ec04-fbb5-8063-d334-1e8208853b14@tarantool.org \
--to=okoshovetc@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: add test filter for vinyl/errinj.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox