From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <okoshovetc@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7E37245C304
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Dec 2020 18:29:13 +0300 (MSK)
References: <83b8e393ad82dd9eb40271b62bb1258ad72cee38.1607443162.git.avtikhon@tarantool.org>
From: Oleg Koshovetc <okoshovetc@tarantool.org>
Message-ID: <e389ec04-fbb5-8063-d334-1e8208853b14@tarantool.org>
Date: Thu, 10 Dec 2020 18:28:27 +0300
MIME-Version: 1.0
In-Reply-To: <83b8e393ad82dd9eb40271b62bb1258ad72cee38.1607443162.git.avtikhon@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH v1] test: add test filter for
 vinyl/errinj.test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM

NIT:

After concatenation the final command will look like "push filter 
'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'to 'Invalid 
VYLOG file: Slice <NUM> deleted but not registered'" with missing space 
before "to". As far as I am concerned this is still going to be parsed 
correctly, however I would like to see a space there.

On 08.12.2020 19:00, Alexander V. Tikhonov via Tarantool-patches wrote:
> Cc: tarantool-patches@dev.tarantool.org
>
> Added test-run filter on box.snapshot error message:
>
>    'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'
>
> to avoid of printing changing data in results file to be able to use
> its checksums in fragile list of test-run to rerun it as flaky issue.
>
> Needed for #4346
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4346-filter-output
> Issue: https://github.com/tarantool/tarantool/issues/4346
>
>   test/vinyl/errinj.result   | 5 +++++
>   test/vinyl/errinj.test.lua | 4 ++++
>   2 files changed, 9 insertions(+)
>
> diff --git a/test/vinyl/errinj.result b/test/vinyl/errinj.result
> index bf49f4e46..6f12e2b4a 100644
> --- a/test/vinyl/errinj.result
> +++ b/test/vinyl/errinj.result
> @@ -10,6 +10,11 @@ fiber = require('fiber')
>   errinj = box.error.injection
>   ---
>   ...
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> +             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +---
> +- true
> +...
>   --
>   -- Lost data in case of dump error
>   --
> diff --git a/test/vinyl/errinj.test.lua b/test/vinyl/errinj.test.lua
> index 2c8121364..cdc695e1b 100644
> --- a/test/vinyl/errinj.test.lua
> +++ b/test/vinyl/errinj.test.lua
> @@ -2,6 +2,10 @@ test_run = require('test_run').new()
>   fio = require('fio')
>   fiber = require('fiber')
>   errinj = box.error.injection
> +
> +test_run:cmd("push filter 'Invalid VYLOG file: Slice [0-9]+ deleted but not registered'" .. \
> +             "to 'Invalid VYLOG file: Slice <NUM> deleted but not registered'")
> +
>   --
>   -- Lost data in case of dump error
>   --