Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
	tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 3/3] test: box-tap/gc -- add test for is_paused field
Date: Wed, 24 Mar 2021 16:27:05 +0300	[thread overview]
Message-ID: <f19016d1-5443-eb9e-7e8d-1e0da287f3f9@tarantool.org> (raw)
In-Reply-To: <20210323154710.1696442-4-gorcunov@gmail.com>



23.03.2021 18:47, Cyrill Gorcunov пишет:
> Once simple bootstrap is complete and there is no
> replicas used we should run with gc unpaused.
>
> Part-of #5806
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   test/box-tap/gc.test.lua | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/box-tap/gc.test.lua b/test/box-tap/gc.test.lua
> index f0155779c..ced87547e 100755
> --- a/test/box-tap/gc.test.lua
> +++ b/test/box-tap/gc.test.lua
> @@ -8,11 +8,12 @@ local debug = type(box.error.injection) == "table"
>   
>   -- check box.info.gc() is false if snapshot is not in progress
>   local test = tap.test('box.info.gc')
> -test:plan(1 + (debug and 1 or 0))
> +test:plan(2 + (debug and 1 or 0))
>   
>   
>   local gc = box.info.gc()
>   test:is(gc.checkpoint_is_in_progress, false, "checkpoint is not in progress")
> +test:is(gc.is_paused, false, "GC is not paused")
>   
>   -- check box.info.gc() is true if snapshot is in progress
>   --
Thanks for the patch!
LGTM.

-- 
Serge Petrenko


  reply	other threads:[~2021-03-24 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 15:47 [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:09   ` Serge Petrenko via Tarantool-patches
2021-03-24 15:00     ` Cyrill Gorcunov via Tarantool-patches
2021-03-25  7:12       ` Serge Petrenko via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:20   ` Serge Petrenko via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:27   ` Serge Petrenko via Tarantool-patches [this message]
2021-03-23 18:33 ` [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
2021-03-23 19:07   ` Cyrill Gorcunov via Tarantool-patches
2021-03-24 12:47 ` Serge Petrenko via Tarantool-patches
2021-03-24 14:42   ` Cyrill Gorcunov via Tarantool-patches
2021-03-25  7:13     ` Serge Petrenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f19016d1-5443-eb9e-7e8d-1e0da287f3f9@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 3/3] test: box-tap/gc -- add test for is_paused field' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox