From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7974A6FC86; Wed, 24 Mar 2021 16:27:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7974A6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616592428; bh=xzboV4wpM70XJU6NEOTQMZ66tlgTkntPOSGMM6PMYK4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VBHJIyhdsdozCYpslOavho7mYyPAZ5de3zSftQ3Sy5xPlIhwRA6PRuMGX/HT2McNK EIVXIK+aETjkphRm3ey+dfY+dka2yZR1XaAqdUhWBBHOKTx5O6CKwl7TRKV8CIt2ne dEJQlXCS4rH95VIuGea3CXD8rddrUonf7LuJTENs= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB45A6FC86 for ; Wed, 24 Mar 2021 16:27:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB45A6FC86 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lP3XN-0004i5-Rb; Wed, 24 Mar 2021 16:27:06 +0300 To: Cyrill Gorcunov , tml References: <20210323154710.1696442-1-gorcunov@gmail.com> <20210323154710.1696442-4-gorcunov@gmail.com> Message-ID: Date: Wed, 24 Mar 2021 16:27:05 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323154710.1696442-4-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F10D3016C09B407F8B88411E9FEB481E8E182A05F5380850409BCF8649114073C4091FB00A7FF802BEED7E038D03F6CBF0915170BF9B273F26 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379428F6EA0D091379EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC766492B72D9EB27871EC5BB59445BF6237A2C85FF1C20B305425389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E34F43C7A68FF626056395957E7521B51C29E9CE733340B9D5F68655334FD4449CB9ECD01F8117BC8BEE2021AF6380DFAD19449624AB7ADAF3735872C767BF85DA29E625A9149C048EE0A3850AC1BE2E7355E1C53F199C2BB95C8A9BA7A39EFB7666BA297DBC24807EA089D37D7C0E48F6C8AA50765F790063710A74FE5B09D3CF8731C566533BA786A40A5AABA2AD371193C9F3DD0FB1AF5EB82E77451A5C57BD33C9F3DD0FB1AF5EB4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5902EDE59A2C5FAC249FE8981EADCAC91A32048312F3CC41BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B7CBFF60649FF2669F121EA69E02FF14CAF533F2D3C1F239C8569048CB64E93F9E99FDD976A0D7F31D7E09C32AA3244CD1998D4CF62DC5ADFD9BE69B4B201A205A1673A01BA68E40927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNqBGwjEnRoVoj+RBHaQ+cg== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4467BDA88733191CC0D67AB8CAFB7C7BD4C6CD94E02192C25FD424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 3/3] test: box-tap/gc -- add test for is_paused field X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 23.03.2021 18:47, Cyrill Gorcunov пишет: > Once simple bootstrap is complete and there is no > replicas used we should run with gc unpaused. > > Part-of #5806 > > Signed-off-by: Cyrill Gorcunov > --- > test/box-tap/gc.test.lua | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/box-tap/gc.test.lua b/test/box-tap/gc.test.lua > index f0155779c..ced87547e 100755 > --- a/test/box-tap/gc.test.lua > +++ b/test/box-tap/gc.test.lua > @@ -8,11 +8,12 @@ local debug = type(box.error.injection) == "table" > > -- check box.info.gc() is false if snapshot is not in progress > local test = tap.test('box.info.gc') > -test:plan(1 + (debug and 1 or 0)) > +test:plan(2 + (debug and 1 or 0)) > > > local gc = box.info.gc() > test:is(gc.checkpoint_is_in_progress, false, "checkpoint is not in progress") > +test:is(gc.is_paused, false, "GC is not paused") > > -- check box.info.gc() is true if snapshot is in progress > -- Thanks for the patch! LGTM. -- Serge Petrenko