From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed
Date: Tue, 23 Mar 2021 22:07:53 +0300 [thread overview]
Message-ID: <YFo8ibNU2ntPPDR0@grain> (raw)
In-Reply-To: <YFo0iZ5g/n5t/YLu@grain>
On Tue, Mar 23, 2021 at 09:33:45PM +0300, Cyrill Gorcunov wrote:
> >
> > issue https://github.com/tarantool/tarantool/issues/5806
> > branch gorcunov/gh-5806-xlog-gc-3
>
> I just noticed that with this change the test replication/replica_rejoin.test.lua
> started to fail. Investigating. I think it is due to default timeout.
As far as I understand this is because our wal_cleanup_delay is not zero by default
and doesn't allow to purge old xlog files until relays are connected back. In turn
the test does exactly the reverse -- it expects main node to purge old xlogs.
Actully I'm not sure what to do -- we can tune up the test case (ie explicitly set
wal_cleanup_delay to 0) and it start passing but this looks like some backward
compatiblity breakage: can't there be someone who relies to old behaviour? If so
we should set wal_cleanup_delay to 0 by default, no?
Cyrill
next prev parent reply other threads:[~2021-03-23 19:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 15:47 Cyrill Gorcunov via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:09 ` Serge Petrenko via Tarantool-patches
2021-03-24 15:00 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 7:12 ` Serge Petrenko via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:20 ` Serge Petrenko via Tarantool-patches
2021-03-23 15:47 ` [Tarantool-patches] [PATCH v3 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
2021-03-24 13:27 ` Serge Petrenko via Tarantool-patches
2021-03-23 18:33 ` [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed Cyrill Gorcunov via Tarantool-patches
2021-03-23 19:07 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-03-24 12:47 ` Serge Petrenko via Tarantool-patches
2021-03-24 14:42 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 7:13 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFo8ibNU2ntPPDR0@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox