Re: [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

23.03.2021 18:47, Cyrill Gorcunov пишет:
> Take a look please.
>
> v2:
>   - rebase code to the fresh master branch
>   - keep wal_cleanup_delay option name
>   - pass wal_cleanup_delay as an option to gc_init, so it
>     won't be dependent on cfg engine
>   - add comment about gc_delay_unref in plain bootstrap mode
>   - allow to setup wal_cleanup_delay dynamically
>   - update comment in gc_wait_cleanup and call it conditionally
>   - declare wal_cleanup_delay as a double
>   - rename gc.cleanup_is_paused to gc.is_paused and update output
>   - do not show ref counter in box.info.gc() output
>   - update documentation
>   - move gc_delay_unref inside relay_subscribe call which runs
>     in tx context (instead of relay's context)
>   - update tests:
>     - add a comment why we need a temp space on replica node
>     - use explicit insert/snapshot operations
>     - shrkink the number of insert/snapshot to speedup testing
>     - use "restart" instead of stop/start pair
>     - use wait_log helper instead of own function
>     - add is_paused test
> v3:
>   - fix changelog
>   - rework box_check_wal_cleanup_delay, the replication_anon
>     setting is considered only in box_set_wal_cleanup_delay,
>     ie when config is checked and parsed, moreover the order
>     of setup is set to be behind "replication_anon" option
>     processing
>   - delay cycle now considers deadline instead of per cycle
>     calculation
>   - use `double` type for timestamp
>   - test update
>     - verify `.is_paused` value
>     - minimize number of inserts
>     - no need to use temporary space, regular space works as well
>     - add comments on why we should restart the master node
>
> issue https://github.com/tarantool/tarantool/issues/5806
> branch gorcunov/gh-5806-xlog-gc-3

Looks like you've deleted the branch accidentally.

>
> Cyrill Gorcunov (3):
>    gc/xlog: delay xlog cleanup until relays are subscribed
>    test: add a test for wal_cleanup_delay option
>    test: box-tap/gc -- add test for is_paused field
>
>   .../unreleased/add-wal_cleanup_delay.md       |   5 +
>   src/box/box.cc                                |  43 ++-
>   src/box/box.h                                 |   1 +
>   src/box/gc.c                                  |  88 ++++-
>   src/box/gc.h                                  |  38 +-
>   src/box/lua/cfg.cc                            |   9 +
>   src/box/lua/info.c                            |   4 +
>   src/box/lua/load_cfg.lua                      |   5 +
>   src/box/relay.cc                              |   1 +
>   src/box/replication.cc                        |   2 +
>   test/app-tap/init_script.result               |   1 +
>   test/box-tap/gc.test.lua                      |   3 +-
>   test/box/admin.result                         |   2 +
>   test/box/cfg.result                           |   4 +
>   test/replication/gh-5806-master.lua           |   8 +
>   test/replication/gh-5806-slave.lua            |   8 +
>   test/replication/gh-5806-xlog-cleanup.result  | 356 ++++++++++++++++++
>   .../replication/gh-5806-xlog-cleanup.test.lua | 155 ++++++++
>   test/unit/snap_quorum_delay.cc                |   2 +-
>   19 files changed, 726 insertions(+), 9 deletions(-)
>   create mode 100644 changelogs/unreleased/add-wal_cleanup_delay.md
>   create mode 100644 test/replication/gh-5806-master.lua
>   create mode 100644 test/replication/gh-5806-slave.lua
>   create mode 100644 test/replication/gh-5806-xlog-cleanup.result
>   create mode 100644 test/replication/gh-5806-xlog-cleanup.test.lua
>
>
> base-commit: f4e248c0c13a46beee238fbebc38ef687ef09d02

-- 
Serge Petrenko