From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E747F6FC86; Wed, 24 Mar 2021 15:48:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E747F6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616590082; bh=ZNnjM/Bv8OrQMrPCNI7selEFTzNcxyJMWgkfzz7bBWA=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=obA4vj7uLMUyPkniTrgv6UOeWa1uGIbF+NElURvW1nXDSx51zwFOCY6+78XGwWSPy VSKiW6Ah4Pg21X5h4kWbrzI0nNuw3vzq5qULWC9WhWMq7qFbEDfgmoHfg616akYXsC nE1CrbU1UJNPpDAaVoBK9TB7E4Yn9g8jwi2eSNX0= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B213B6FC86 for ; Wed, 24 Mar 2021 15:48:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B213B6FC86 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1lP2vX-0001ZI-Ex; Wed, 24 Mar 2021 15:47:59 +0300 To: Cyrill Gorcunov , tml References: <20210323154710.1696442-1-gorcunov@gmail.com> Message-ID: <0a1f201d-27ae-734a-9d04-677e56728a96@tarantool.org> Date: Wed, 24 Mar 2021 15:47:59 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323154710.1696442-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F1C82687294EF6886B62CC997B0B8C95C4182A05F53808504054F37AF2B83F4C7F3C3C125344F312B5C70841B51897C9310DE169A5F3BAF81F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78887611F2F2455C9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D332FFE8BBF4EB58638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DC97519AE9D14236B46D3459D92108BFCA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFE454F552B5E65C9ABA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6F9B9CA068602C43876E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B3BBE47FD9DD3FB59A8DF7F3B2552694A2BEBFE083D3B9BA73A03B725D353964BB11811A4A51E3B096D1867E19FE14079BA9C0B312567BB23089D37D7C0E48F6CA18204E546F3947CF841BD135A60A31742539A7722CA490CC8A9BA7A39EFB7666BA297DBC24807EA089D37D7C0E48F6C8AA50765F790063749630363B3EBCB7CEFF80C71ABB335746BA297DBC24807EA27F269C8F02392CD20465B3A5AADEC6827F269C8F02392CD5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5FCFB7949D4E64E3012ED421D6B1674ADB7C13CAEDAA8A722D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F1ADD4D8CD3C81CE451BAF55E7831DCCE2C52F560186F140B653348FCE30CF8F0A263DFFD21E08771D7E09C32AA3244CAF9FB296941B021D1F4FD2F3812113F8F26BFA4C8A6946B8927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNqBGwjEnRoW3b6h6tW2T/Q== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F888F008759276C6FA7B65EF5F92599B20053BB975106163A1424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 23.03.2021 18:47, Cyrill Gorcunov пишет: > Take a look please. > > v2: > - rebase code to the fresh master branch > - keep wal_cleanup_delay option name > - pass wal_cleanup_delay as an option to gc_init, so it > won't be dependent on cfg engine > - add comment about gc_delay_unref in plain bootstrap mode > - allow to setup wal_cleanup_delay dynamically > - update comment in gc_wait_cleanup and call it conditionally > - declare wal_cleanup_delay as a double > - rename gc.cleanup_is_paused to gc.is_paused and update output > - do not show ref counter in box.info.gc() output > - update documentation > - move gc_delay_unref inside relay_subscribe call which runs > in tx context (instead of relay's context) > - update tests: > - add a comment why we need a temp space on replica node > - use explicit insert/snapshot operations > - shrkink the number of insert/snapshot to speedup testing > - use "restart" instead of stop/start pair > - use wait_log helper instead of own function > - add is_paused test > v3: > - fix changelog > - rework box_check_wal_cleanup_delay, the replication_anon > setting is considered only in box_set_wal_cleanup_delay, > ie when config is checked and parsed, moreover the order > of setup is set to be behind "replication_anon" option > processing > - delay cycle now considers deadline instead of per cycle > calculation > - use `double` type for timestamp > - test update > - verify `.is_paused` value > - minimize number of inserts > - no need to use temporary space, regular space works as well > - add comments on why we should restart the master node > > issue https://github.com/tarantool/tarantool/issues/5806 > branch gorcunov/gh-5806-xlog-gc-3 Looks like you've deleted the branch accidentally. > > Cyrill Gorcunov (3): > gc/xlog: delay xlog cleanup until relays are subscribed > test: add a test for wal_cleanup_delay option > test: box-tap/gc -- add test for is_paused field > > .../unreleased/add-wal_cleanup_delay.md | 5 + > src/box/box.cc | 43 ++- > src/box/box.h | 1 + > src/box/gc.c | 88 ++++- > src/box/gc.h | 38 +- > src/box/lua/cfg.cc | 9 + > src/box/lua/info.c | 4 + > src/box/lua/load_cfg.lua | 5 + > src/box/relay.cc | 1 + > src/box/replication.cc | 2 + > test/app-tap/init_script.result | 1 + > test/box-tap/gc.test.lua | 3 +- > test/box/admin.result | 2 + > test/box/cfg.result | 4 + > test/replication/gh-5806-master.lua | 8 + > test/replication/gh-5806-slave.lua | 8 + > test/replication/gh-5806-xlog-cleanup.result | 356 ++++++++++++++++++ > .../replication/gh-5806-xlog-cleanup.test.lua | 155 ++++++++ > test/unit/snap_quorum_delay.cc | 2 +- > 19 files changed, 726 insertions(+), 9 deletions(-) > create mode 100644 changelogs/unreleased/add-wal_cleanup_delay.md > create mode 100644 test/replication/gh-5806-master.lua > create mode 100644 test/replication/gh-5806-slave.lua > create mode 100644 test/replication/gh-5806-xlog-cleanup.result > create mode 100644 test/replication/gh-5806-xlog-cleanup.test.lua > > > base-commit: f4e248c0c13a46beee238fbebc38ef687ef09d02 -- Serge Petrenko