From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring Date: Thu, 8 Apr 2021 00:52:48 +0200 [thread overview] Message-ID: <dd736640-54bd-b786-6792-ca47f5598f5a@tarantool.org> (raw) In-Reply-To: <YG4g2drj9b5VrK5n@grain> On 07.04.2021 23:15, Cyrill Gorcunov wrote: > On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch! >> >> See 7 comments below. >> >>> qsync: provide box.info interface for monitoring >>> >>> Since commit 14fa5fd82 we support symbolic evaluation of >> >> 1. Please, after a commit hash provide the referenced commit >> title in parentheses and quotes. >> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > > Maybe worth to add an example then? Something like There is an example, see the link above. > [cyrill@grain tarantool.git] git log --pretty=reference -1 14fa5fd82 > 14fa5fd82 (cfg: support symbolic evaluation of replication_synchro_quorum, 2020-12-03) > >>> Thus we introduce the "synchro" leaf in box.info interface. >>> For now only a few entries are printed out >>> >>> | tarantool> box.info.synchro >>> | --- >>> | - queue: >>> | 1: >>> | len: 0 >>> | quorum: 1 >>> | ... >> >> 2. AFAIK, it was decided not to return an array, and return only >> the currently used queue. But even if it would be an array, as I >> said in the previous review, the indexing must be by box.info.id, >> not by any order. Assume there are multiple limbos, and the master is >> not instance_id = 1. How is a user supposed to find what is the >> queue in the currently used limbo? And what is the currently used >> limbo? > > Wait, Vlad, this is v2, while I sent v3 already where tried to address > the formatting > > https://lists.tarantool.org/tarantool-patches/YGt0TACA8xe6N7Rr@grain/ > > In short I use > > Thus we introduce the "synchro" leaf in box.info interface. > For now only a few entries are printed out > > | tarantool> box.info.synchro > | --- > | - queue: > | len: 0 > | quorum: 1 > | ... > > The `queue` represents limbo instance and `len` member > shows the number of entries in the queue. Note that if > we gonna support multiple queues then we might create > a separate `queues` array to cover all possible instances. > > The `quorum` member shows the evaluated value of > `replication_synchro_quorum` parameter. > > Your comments are still relevant and I'll address them > in v4 but please make sure the output above is exactly > what you prefer? The output looks good. Sorry, I missed v3 version. Saw it in the same thread, but thought it is just some follow-up for v2 and didn't read carefully enough, or maybe marked as read accidentally, I don't remember. Anyway, waiting for a new version now.
next prev parent reply other threads:[~2021-04-07 22:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 15:58 Cyrill Gorcunov via Tarantool-patches 2021-04-05 20:34 ` [Tarantool-patches] [PATCH v3] " Cyrill Gorcunov via Tarantool-patches 2021-04-08 7:34 ` Serge Petrenko via Tarantool-patches 2021-04-08 7:40 ` Cyrill Gorcunov via Tarantool-patches 2021-04-07 20:53 ` [Tarantool-patches] [PATCH v2] " Vladislav Shpilevoy via Tarantool-patches 2021-04-07 21:15 ` Cyrill Gorcunov via Tarantool-patches 2021-04-07 22:52 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-04-08 7:11 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 19:37 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-08 19:54 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 19:57 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-08 20:04 ` Cyrill Gorcunov via Tarantool-patches 2021-04-08 20:10 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-08 20:19 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=dd736640-54bd-b786-6792-ca47f5598f5a@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox