Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring
Date: Thu, 8 Apr 2021 22:10:41 +0200	[thread overview]
Message-ID: <d2101da0-4a03-5ab1-20af-22256809b91c@tarantool.org> (raw)
In-Reply-To: <YG9h30392skq8MJq@grain>

On 08.04.2021 22:04, Cyrill Gorcunov via Tarantool-patches wrote:
> On Thu, Apr 08, 2021 at 09:57:17PM +0200, Vladislav Shpilevoy wrote:
>>>
>>> git show generates the whole commit including its body.
>>> It is simply not needed for oneline requirement.
>>
>> But you are a human, right? So you can just copy-paste the
>> first line. It is not super hard. You just need to select it,
>> do 'Ctrl + C', and then 'Ctrl + V' in your new commit message.
>> Easy!
>>
>> If you consider it somehow not acceptable or extremely longer
>> than your way, you can create a script/alias doing it for you.
>> You just need to omit the date, and still add line breaks if
>> the line in your new commit message becomes too long.
> 
> Look, git already has the helper which does exactly what you
> prefer to see in output. I simply added this command to the
> our code-review page. If you don't like this example with
> `git log --pretty=format:"%h (%s)"` feel free to remove it
> from the page.

Nope, I won't. The command is useful if somebody else would complain
they need a special command for that. All the amendments to the
self-review guide are appreciated.

  reply	other threads:[~2021-04-08 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 15:58 Cyrill Gorcunov via Tarantool-patches
2021-04-05 20:34 ` [Tarantool-patches] [PATCH v3] " Cyrill Gorcunov via Tarantool-patches
2021-04-08  7:34   ` Serge Petrenko via Tarantool-patches
2021-04-08  7:40     ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 20:53 ` [Tarantool-patches] [PATCH v2] " Vladislav Shpilevoy via Tarantool-patches
2021-04-07 21:15   ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 22:52     ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08  7:11       ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:37         ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 19:54           ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:57             ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 20:04               ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 20:10                 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-08 20:19                   ` Cyrill Gorcunov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2101da0-4a03-5ab1-20af-22256809b91c@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox