From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring
Date: Thu, 8 Apr 2021 21:37:54 +0200 [thread overview]
Message-ID: <d3c81486-5e1c-61cf-3c12-1b27e867de0e@tarantool.org> (raw)
In-Reply-To: <YG6spNcsF/5CjF2r@grain>
On 08.04.2021 09:11, Cyrill Gorcunov wrote:
> On Thu, Apr 08, 2021 at 12:52:48AM +0200, Vladislav Shpilevoy wrote:
>> On 07.04.2021 23:15, Cyrill Gorcunov wrote:
>>> On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote:
>>>> Hi! Thanks for the patch!
>>>>
>>>> See 7 comments below.
>>>>
>>>>> qsync: provide box.info interface for monitoring
>>>>>
>>>>> Since commit 14fa5fd82 we support symbolic evaluation of
>>>>
>>>> 1. Please, after a commit hash provide the referenced commit
>>>> title in parentheses and quotes.
>>>> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message
>>>
>>> Maybe worth to add an example then? Something like
>>
>> There is an example, see the link above.
>
> There is a result example but no any hints on how to generate it. I added to the page
> an example of use `git log --pretty=format ...`.
You just do 'git show' on your hash and copy-paste the message.
I don't see anything hard in it.
next prev parent reply other threads:[~2021-04-08 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 15:58 Cyrill Gorcunov via Tarantool-patches
2021-04-05 20:34 ` [Tarantool-patches] [PATCH v3] " Cyrill Gorcunov via Tarantool-patches
2021-04-08 7:34 ` Serge Petrenko via Tarantool-patches
2021-04-08 7:40 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 20:53 ` [Tarantool-patches] [PATCH v2] " Vladislav Shpilevoy via Tarantool-patches
2021-04-07 21:15 ` Cyrill Gorcunov via Tarantool-patches
2021-04-07 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 7:11 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:37 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-08 19:54 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 19:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 20:04 ` Cyrill Gorcunov via Tarantool-patches
2021-04-08 20:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-08 20:19 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c81486-5e1c-61cf-3c12-1b27e867de0e@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox