From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 556E86EC5D; Thu, 8 Apr 2021 22:37:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 556E86EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617910676; bh=HY5tVpa7PwmZDHGIsGqxOk/9xtHHUZQzHXZKiyneS80=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IG22Xad6Fl7mhErAsQkJEgmDAU3d5qdS18d8JXHe6LVNaes3wAe6dUs8Po+BK0plY WdGygVSumVOTl0fQexk6CgdWrWXavTRupytfp/hsupcPvvkvsYO2GiWbPi15mf6tE2 O21+Fatfg6CchwzgJ2XHxtHO3oOXRTqEhUFlXUhQ= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C26F06EC5D for ; Thu, 8 Apr 2021 22:37:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C26F06EC5D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lUaTT-0004qt-6t; Thu, 08 Apr 2021 22:37:55 +0300 To: Cyrill Gorcunov Cc: tml References: <20210405155823.1121042-1-gorcunov@gmail.com> Message-ID: Date: Thu, 8 Apr 2021 21:37:54 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E74807BAE725B9AE625DE765B0E193B5B7687182A05F538085040781F8229DE36D0E83494AA89864721F630BC668F3C07D7ACFA4678B0226BE83E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E280A1EC162AD7D8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B27DDF258082E4A48CD0382B62D77C10EE3C8827A907CBE77DD2E47CDBA5A96583C09775C1D3CA48CFE478A468B35FE767117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B5E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5366CD1A6BBF262A761A8EDB99634F9B4FB2E9F49C0824414D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C6EC1BD9807109D2C94A7410C98FCF3F6E76546EF574390C015C9312995A5085AC0A2602B4CCE8361D7E09C32AA3244C5ACDFD4E06DE06F2EC05D3775819C9D1BBA718C7E6A9E042729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyO2lHpuZu4SqN+ILZCN15Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638222881C60B5203DB78186349F8A164413A3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 08.04.2021 09:11, Cyrill Gorcunov wrote: > On Thu, Apr 08, 2021 at 12:52:48AM +0200, Vladislav Shpilevoy wrote: >> On 07.04.2021 23:15, Cyrill Gorcunov wrote: >>> On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote: >>>> Hi! Thanks for the patch! >>>> >>>> See 7 comments below. >>>> >>>>> qsync: provide box.info interface for monitoring >>>>> >>>>> Since commit 14fa5fd82 we support symbolic evaluation of >>>> >>>> 1. Please, after a commit hash provide the referenced commit >>>> title in parentheses and quotes. >>>> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message >>> >>> Maybe worth to add an example then? Something like >> >> There is an example, see the link above. > > There is a result example but no any hints on how to generate it. I added to the page > an example of use `git log --pretty=format ...`. You just do 'git show' on your hash and copy-paste the message. I don't see anything hard in it.