From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 259056EC5D; Thu, 8 Apr 2021 01:52:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 259056EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617835970; bh=hLcIJhZds2172fkHnL9CVBryam5im5uCGfgDCn9fJiM=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=w6WT2jG3V0OcVtBo6+qFtspwsQCrMOchpNwTJ7PG6Pj2n8vd9AVUqxLD7Ur14aTAF HxEpSSbbkoY+E9OX6pIhXd6IDvkeIyCtxzmbPcRuKDXTkarsfwiL5M7XKEWpL3Oc4v 5v2Pmeb8a/tsbA4Hq+75sDY9KCJrBo2KRV4airX8= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A33006EC5D for ; Thu, 8 Apr 2021 01:52:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A33006EC5D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lUH2X-0005VF-4h; Thu, 08 Apr 2021 01:52:49 +0300 To: Cyrill Gorcunov Cc: tml References: <20210405155823.1121042-1-gorcunov@gmail.com> Message-ID: Date: Thu, 8 Apr 2021 00:52:48 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1FB6C11AAC314D64EDF2811C24C4EA09700894C459B0CD1B977E4D7740FEBB47352ED1D64AC7699371BF0955E13D06867808768E5B14F6D12 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764FE777F378F21448638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2580B1EC7F3CAF52B8D00023A38DDDD9389428004B1FE94FDD2E47CDBA5A96583C09775C1D3CA48CF4964A708C60C975A117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7850F8B975A76562C9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F9FFED5BD9FB41755CE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831C0DAA46F034E6B67437CCAE968C07DD4 X-C1DE0DAB: 0D63561A33F958A5F660D67B7EEEEE0B854B004DED3E37A1030D6EA38B4F79C9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342C0B628602DFD0BC6DE6EBF606254706D1D7C9800324E9A890D0E2A7208A9D81363601816756E8251D7E09C32AA3244CA9729DB393C703B53D0FA3E044B4D2C6C86C126E7119A0FE729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXqerUQnvNNXcQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822AF4882CCFFD37E1D50C6F784E646AD763841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2] qsync: provide box.info interface for monitoring X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 07.04.2021 23:15, Cyrill Gorcunov wrote: > On Wed, Apr 07, 2021 at 10:53:27PM +0200, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch! >> >> See 7 comments below. >> >>> qsync: provide box.info interface for monitoring >>> >>> Since commit 14fa5fd82 we support symbolic evaluation of >> >> 1. Please, after a commit hash provide the referenced commit >> title in parentheses and quotes. >> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > > Maybe worth to add an example then? Something like There is an example, see the link above. > [cyrill@grain tarantool.git] git log --pretty=reference -1 14fa5fd82 > 14fa5fd82 (cfg: support symbolic evaluation of replication_synchro_quorum, 2020-12-03) > >>> Thus we introduce the "synchro" leaf in box.info interface. >>> For now only a few entries are printed out >>> >>> | tarantool> box.info.synchro >>> | --- >>> | - queue: >>> | 1: >>> | len: 0 >>> | quorum: 1 >>> | ... >> >> 2. AFAIK, it was decided not to return an array, and return only >> the currently used queue. But even if it would be an array, as I >> said in the previous review, the indexing must be by box.info.id, >> not by any order. Assume there are multiple limbos, and the master is >> not instance_id = 1. How is a user supposed to find what is the >> queue in the currently used limbo? And what is the currently used >> limbo? > > Wait, Vlad, this is v2, while I sent v3 already where tried to address > the formatting > > https://lists.tarantool.org/tarantool-patches/YGt0TACA8xe6N7Rr@grain/ > > In short I use > > Thus we introduce the "synchro" leaf in box.info interface. > For now only a few entries are printed out > > | tarantool> box.info.synchro > | --- > | - queue: > | len: 0 > | quorum: 1 > | ... > > The `queue` represents limbo instance and `len` member > shows the number of entries in the queue. Note that if > we gonna support multiple queues then we might create > a separate `queues` array to cover all possible instances. > > The `quorum` member shows the evaluated value of > `replication_synchro_quorum` parameter. > > Your comments are still relevant and I'll address them > in v4 but please make sure the output above is exactly > what you prefer? The output looks good. Sorry, I missed v3 version. Saw it in the same thread, but thought it is just some follow-up for v2 and didn't read carefully enough, or maybe marked as read accidentally, I don't remember. Anyway, waiting for a new version now.