Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow
Date: Thu, 13 Jun 2024 18:06:13 +0300	[thread overview]
Message-ID: <dc21ae01-fe1e-40e1-aa50-5a79fd6b0aac@tarantool.org> (raw)
In-Reply-To: <ZmrLjJh_Ow6njCZo@root>

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

Hi, Sergey


LGTM

On 13.06.2024 13:35, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Please consider my answers below.
>
> On 07.06.24, Sergey Bronnikov wrote:
>> Sergey,
>>
>>
>> thanks for the patch! See my comments below.
>>
>> Sergey
>>
>> On 15.05.2024 15:32, Sergey Kaplun wrote:
>>> Relates to tarantool/tarantool#8473
>>> ---
>>>    .github/workflows/sanitizers-testing.yml | 8 ++++++--
>>>    1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
>>> index 154ebe40..4bf7d023 100644
>>> --- a/.github/workflows/sanitizers-testing.yml
>>> +++ b/.github/workflows/sanitizers-testing.yml
> <snipped>
>
>>> @@ -91,5 +92,8 @@ jobs:
>>>                symbolize=1:                     \
>>>                unmap_shadow_on_exit=1:          \
>>>              "
>>> +          UBSAN_OPTIONS: "
>>> +            print_stacktrace=1 \
>> I propose to move these env variables to CMake.
> I suppose this is the same reason as for ASAN options: when run the asan
> + lsan CI in the tarantool repository, it configures its own ASAN +
> UBSAN options. To avoid their overwriting in our CMake file, we don't
> include this part there.
Got it, thanks!
>>> +          "
>>>            run: cmake --build . --parallel --target LuaJIT-test
>>>            working-directory: ${{ env.BUILDDIR }}

[-- Attachment #2: Type: text/html, Size: 2600 bytes --]

  reply	other threads:[~2024-06-13 15:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 12:31 [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches
2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_UBSAN option Sergey Kaplun via Tarantool-patches
2024-05-16 10:14   ` Sergey Kaplun via Tarantool-patches
2024-05-26  9:56     ` Maxim Kokryashkin via Tarantool-patches
2024-05-27  7:22       ` Sergey Kaplun via Tarantool-patches
2024-05-27  8:28         ` Maxim Kokryashkin via Tarantool-patches
2024-06-20 10:01     ` Sergey Bronnikov via Tarantool-patches
2024-06-20 10:03       ` Sergey Kaplun via Tarantool-patches
2024-05-27  8:52   ` Maxim Kokryashkin via Tarantool-patches
2024-05-27 12:28     ` Sergey Kaplun via Tarantool-patches
2024-06-14 12:03       ` Maxim Kokryashkin via Tarantool-patches
2024-06-07 10:17   ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:56     ` Sergey Kaplun via Tarantool-patches
2024-06-13 15:13       ` Sergey Bronnikov via Tarantool-patches
2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow Sergey Kaplun via Tarantool-patches
2024-05-26  9:50   ` Maxim Kokryashkin via Tarantool-patches
2024-05-27 12:30     ` Sergey Kaplun via Tarantool-patches
2024-06-07 10:20   ` Sergey Bronnikov via Tarantool-patches
2024-06-13 10:35     ` Sergey Kaplun via Tarantool-patches
2024-06-13 15:06       ` Sergey Bronnikov via Tarantool-patches [this message]
2024-07-09  8:06 ` [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc21ae01-fe1e-40e1-aa50-5a79fd6b0aac@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox