From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow Date: Fri, 7 Jun 2024 13:20:06 +0300 [thread overview] Message-ID: <136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org> (raw) In-Reply-To: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 1667 bytes --] Sergey, thanks for the patch! See my comments below. Sergey On 15.05.2024 15:32, Sergey Kaplun wrote: > Relates to tarantool/tarantool#8473 > --- > .github/workflows/sanitizers-testing.yml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml > index 154ebe40..4bf7d023 100644 > --- a/.github/workflows/sanitizers-testing.yml > +++ b/.github/workflows/sanitizers-testing.yml > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > runs-on: [self-hosted, regular, Linux, x86_64] > name: > > - LuaJIT with ASan (Linux/x86_64) > + LuaJIT with ASan and UBSan (Linux/x86_64) > ${{ matrix.BUILDTYPE }} > CC:${{ matrix.CC }} > GC64:ON SYSMALLOC:ON > @@ -70,9 +70,10 @@ jobs: > cmake -S . -B ${{ env.BUILDDIR }} > -G Ninja > ${{ matrix.CMAKEFLAGS }} > + -DLUAJIT_ENABLE_GC64=ON > -DLUAJIT_USE_ASAN=ON > -DLUAJIT_USE_SYSMALLOC=ON > - -DLUAJIT_ENABLE_GC64=ON > + -DLUAJIT_USE_UBSAN=ON > - name: build > run: cmake --build . --parallel > working-directory: ${{ env.BUILDDIR }} > @@ -91,5 +92,8 @@ jobs: > symbolize=1: \ > unmap_shadow_on_exit=1: \ > " > + UBSAN_OPTIONS: " > + print_stacktrace=1 \ I propose to move these env variables to CMake. > + " > run: cmake --build . --parallel --target LuaJIT-test > working-directory: ${{ env.BUILDDIR }} [-- Attachment #2: Type: text/html, Size: 2298 bytes --]
next prev parent reply other threads:[~2024-06-07 10:20 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-05-15 12:31 [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches 2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_UBSAN option Sergey Kaplun via Tarantool-patches 2024-05-16 10:14 ` Sergey Kaplun via Tarantool-patches 2024-05-26 9:56 ` Maxim Kokryashkin via Tarantool-patches 2024-05-27 7:22 ` Sergey Kaplun via Tarantool-patches 2024-05-27 8:28 ` Maxim Kokryashkin via Tarantool-patches 2024-06-20 10:01 ` Sergey Bronnikov via Tarantool-patches 2024-06-20 10:03 ` Sergey Kaplun via Tarantool-patches 2024-05-27 8:52 ` Maxim Kokryashkin via Tarantool-patches 2024-05-27 12:28 ` Sergey Kaplun via Tarantool-patches 2024-06-14 12:03 ` Maxim Kokryashkin via Tarantool-patches 2024-06-07 10:17 ` Sergey Bronnikov via Tarantool-patches 2024-06-13 10:56 ` Sergey Kaplun via Tarantool-patches 2024-06-13 15:13 ` Sergey Bronnikov via Tarantool-patches 2024-05-15 12:32 ` [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow Sergey Kaplun via Tarantool-patches 2024-05-26 9:50 ` Maxim Kokryashkin via Tarantool-patches 2024-05-27 12:30 ` Sergey Kaplun via Tarantool-patches 2024-06-07 10:20 ` Sergey Bronnikov via Tarantool-patches [this message] 2024-06-13 10:35 ` Sergey Kaplun via Tarantool-patches 2024-06-13 15:06 ` Sergey Bronnikov via Tarantool-patches 2024-07-09 8:06 ` [Tarantool-patches] [PATCH luajit 0/2] Add UBSan support Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox