From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C39A7B9485B; Fri, 7 Jun 2024 13:20:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C39A7B9485B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1717755609; bh=pKWRJD7mIsPeqnhf+wXysl/QJuvcKsztA9p3uRjB0iQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TA24BeISMF7fcLby9KYn0VidDp25C5HUEWF4vJIlrO6vN5vNO3vHZ3509KCx5wIOU cWU+OM7XzAVt7AHQWAHYlyD5MA4DrCgYKeH0I5v8KFRuV1lRerqlQN0sBA5dtY5JAL azZYDVX/q5BEb6K0WBQbr12kaQ1gxAhPE1Bb+D4U= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [95.163.41.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 717B8B9485B for ; Fri, 7 Jun 2024 13:20:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 717B8B9485B Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1sFWhb-00000003aio-1BUF; Fri, 07 Jun 2024 13:20:07 +0300 Content-Type: multipart/alternative; boundary="------------mgjMmACOP3yMPeUy0YkklPIA" Message-ID: <136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org> Date: Fri, 7 Jun 2024 13:20:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> In-Reply-To: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD948651DF6EBC8E8B27178A04245B6107104D6FF564F87A735182A05F5380850409A51F675395E545EA6D5EE0DB6E1EC8D825F8A3B0CD23A853809A5595D56554428006A18B89A7669 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77AA33865E80AF043EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82C5F2D2DB428632F75DA4534FBC6990879475015A6E54796CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C13BDA61BF53F5E1D302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C369B99345B4CD43D4BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30A3B31C63366F72535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C10752BC519973B95002B1117B3ED696D86BFC3408BFACB8ED71F038FC046993823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF554666337192D8A9025CAAFB25E8431A5A85E9EFD894ABCBC343FF7D0385F9629DCE6E1EBC7C769E00094467C1BF539CC2C0EE44FC6E612CF31BFB80279C2415C2EBD793E439DA335F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojkE9nKBl9ayHVbLp9a7u+nQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458925A2E19764452EF97B151A33FA7A9F86B7623C1EFFA93E49D6A0DB4D54771A5645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------mgjMmACOP3yMPeUy0YkklPIA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, thanks for the patch! See my comments below. Sergey On 15.05.2024 15:32, Sergey Kaplun wrote: > Relates to tarantool/tarantool#8473 > --- > .github/workflows/sanitizers-testing.yml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml > index 154ebe40..4bf7d023 100644 > --- a/.github/workflows/sanitizers-testing.yml > +++ b/.github/workflows/sanitizers-testing.yml > @@ -41,7 +41,7 @@ jobs: > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > runs-on: [self-hosted, regular, Linux, x86_64] > name: > > - LuaJIT with ASan (Linux/x86_64) > + LuaJIT with ASan and UBSan (Linux/x86_64) > ${{ matrix.BUILDTYPE }} > CC:${{ matrix.CC }} > GC64:ON SYSMALLOC:ON > @@ -70,9 +70,10 @@ jobs: > cmake -S . -B ${{ env.BUILDDIR }} > -G Ninja > ${{ matrix.CMAKEFLAGS }} > + -DLUAJIT_ENABLE_GC64=ON > -DLUAJIT_USE_ASAN=ON > -DLUAJIT_USE_SYSMALLOC=ON > - -DLUAJIT_ENABLE_GC64=ON > + -DLUAJIT_USE_UBSAN=ON > - name: build > run: cmake --build . --parallel > working-directory: ${{ env.BUILDDIR }} > @@ -91,5 +92,8 @@ jobs: > symbolize=1: \ > unmap_shadow_on_exit=1: \ > " > + UBSAN_OPTIONS: " > + print_stacktrace=1 \ I propose to move these env variables to CMake. > + " > run: cmake --build . --parallel --target LuaJIT-test > working-directory: ${{ env.BUILDDIR }} --------------mgjMmACOP3yMPeUy0YkklPIA Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,


thanks for the patch! See my comments below.

Sergey

On 15.05.2024 15:32, Sergey Kaplun wrote:
Relates to tarantool/tarantool#8473
---
 .github/workflows/sanitizers-testing.yml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 154ebe40..4bf7d023 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml
@@ -41,7 +41,7 @@ jobs:
             CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
     runs-on: [self-hosted, regular, Linux, x86_64]
     name: >
-      LuaJIT with ASan (Linux/x86_64)
+      LuaJIT with ASan and UBSan (Linux/x86_64)
       ${{ matrix.BUILDTYPE }}
       CC:${{ matrix.CC }}
       GC64:ON SYSMALLOC:ON
@@ -70,9 +70,10 @@ jobs:
           cmake -S . -B ${{ env.BUILDDIR }}
           -G Ninja
           ${{ matrix.CMAKEFLAGS }}
+          -DLUAJIT_ENABLE_GC64=ON
           -DLUAJIT_USE_ASAN=ON
           -DLUAJIT_USE_SYSMALLOC=ON
-          -DLUAJIT_ENABLE_GC64=ON
+          -DLUAJIT_USE_UBSAN=ON
       - name: build
         run: cmake --build . --parallel
         working-directory: ${{ env.BUILDDIR }}
@@ -91,5 +92,8 @@ jobs:
             symbolize=1:                     \
             unmap_shadow_on_exit=1:          \
           "
+          UBSAN_OPTIONS: "
+            print_stacktrace=1 \
I propose to move these env variables to CMake.
+          "
         run: cmake --build . --parallel --target LuaJIT-test
         working-directory: ${{ env.BUILDDIR }}
--------------mgjMmACOP3yMPeUy0YkklPIA--