From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 86272BA2F21; Thu, 13 Jun 2024 18:06:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86272BA2F21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718291175; bh=lGZhz978M8X2kuaNH/HFm8yoP87A6ShqcbLeETdpx/Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SrV5pU0SgVwgJXJgE7wfGZyPSv1wOXvNkoPCSQPGbnRVY2mj2tQNL36rauCZrHAY2 kuct1qu73hCay9H2Gl+zCWvfALj+usp5/Bw/xVWJrqk5xksCjhWn5yVaUezjJMRV86 qXBKMxKtazNHBezztJqkSW+rM2FEIreJmUTMjnTs= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66863BA2F18 for ; Thu, 13 Jun 2024 18:06:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66863BA2F18 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1sHm1l-00000009kha-3383; Thu, 13 Jun 2024 18:06:14 +0300 Content-Type: multipart/alternative; boundary="------------aEMXBQnddQiS0xJ9Hv0s6miu" Message-ID: Date: Thu, 13 Jun 2024 18:06:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> <136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9AC8CA0B4439200FA41DE42749F357741E440C2FC2F02794100894C459B0CD1B979DF8C97697B92D9D8F96DB345880560998E191DF40E20A2F93C88DB3EBEC1A5EDD16E8EE75FCBE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E628FE8A185FCFBEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637645995A778B1BFFAEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3650B9D5276ABB6A2D8740B99A44D5F4C5972A4B45AE005EFDA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF91041352CAA6A1D7BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6D88082464251487476E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C789C969B8F27C422C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5BFEDF7D3499B0FA55002B1117B3ED696E74585863F52A91403803A57F48E4E5A823CB91A9FED034534781492E4B8EEAD9CFA8CFAC159CE19BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEEB0A8EB027734EB02B4324DFDA20FE32C69E608D25BC0B650C307A566624E3C0070534DE2CB11AA04A26A3878DC13302C63D8904DDE32CE03492AC9350699E702A9CBB535AF95095F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AmBwwDhkQohaA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614079DF8C97697B92D9D8F96DB3458805601C7035F7A10D86C20152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------aEMXBQnddQiS0xJ9Hv0s6miu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey LGTM On 13.06.2024 13:35, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answers below. > > On 07.06.24, Sergey Bronnikov wrote: >> Sergey, >> >> >> thanks for the patch! See my comments below. >> >> Sergey >> >> On 15.05.2024 15:32, Sergey Kaplun wrote: >>> Relates to tarantool/tarantool#8473 >>> --- >>> .github/workflows/sanitizers-testing.yml | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml >>> index 154ebe40..4bf7d023 100644 >>> --- a/.github/workflows/sanitizers-testing.yml >>> +++ b/.github/workflows/sanitizers-testing.yml > > >>> @@ -91,5 +92,8 @@ jobs: >>> symbolize=1: \ >>> unmap_shadow_on_exit=1: \ >>> " >>> + UBSAN_OPTIONS: " >>> + print_stacktrace=1 \ >> I propose to move these env variables to CMake. > I suppose this is the same reason as for ASAN options: when run the asan > + lsan CI in the tarantool repository, it configures its own ASAN + > UBSAN options. To avoid their overwriting in our CMake file, we don't > include this part there. Got it, thanks! >>> + " >>> run: cmake --build . --parallel --target LuaJIT-test >>> working-directory: ${{ env.BUILDDIR }} --------------aEMXBQnddQiS0xJ9Hv0s6miu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey


LGTM

On 13.06.2024 13:35, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 07.06.24, Sergey Bronnikov wrote:

Sergey,


thanks for the patch! See my comments below.

Sergey

On 15.05.2024 15:32, Sergey Kaplun wrote:

Relates to tarantool/tarantool#8473
---
  .github/workflows/sanitizers-testing.yml | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 154ebe40..4bf7d023 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml

<snipped>


@@ -91,5 +92,8 @@ jobs:
              symbolize=1:                     \
              unmap_shadow_on_exit=1:          \
            "
+          UBSAN_OPTIONS: "
+            print_stacktrace=1 \

I propose to move these env variables to CMake.

I suppose this is the same reason as for ASAN options: when run the asan
+ lsan CI in the tarantool repository, it configures its own ASAN +
UBSAN options. To avoid their overwriting in our CMake file, we don't
include this part there.
Got it, thanks!

      

        

          
+          "
          run: cmake --build . --parallel --target LuaJIT-test
          working-directory: ${{ env.BUILDDIR }}


        

      

      

    

  
  


--------------aEMXBQnddQiS0xJ9Hv0s6miu--