Hi, Sergey

LGTM

Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 07.06.24, Sergey Bronnikov wrote:

Sergey,


thanks for the patch! See my comments below.

Sergey

On 15.05.2024 15:32, Sergey Kaplun wrote:

Relates to tarantool/tarantool#8473
---
  .github/workflows/sanitizers-testing.yml | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
index 154ebe40..4bf7d023 100644
--- a/.github/workflows/sanitizers-testing.yml
+++ b/.github/workflows/sanitizers-testing.yml

<snipped>

@@ -91,5 +92,8 @@ jobs:
              symbolize=1:                     \
              unmap_shadow_on_exit=1:          \
            "
+          UBSAN_OPTIONS: "
+            print_stacktrace=1 \

I propose to move these env variables to CMake.

I suppose this is the same reason as for ASAN options: when run the asan
+ lsan CI in the tarantool repository, it configures its own ASAN +
UBSAN options. To avoid their overwriting in our CMake file, we don't
include this part there.

+          "
          run: cmake --build . --parallel --target LuaJIT-test
          working-directory: ${{ env.BUILDDIR }}