* [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test
@ 2020-09-05 19:56 Alexander V. Tikhonov
2020-09-09 15:33 ` Serge Petrenko
0 siblings, 1 reply; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-09-05 19:56 UTC (permalink / raw)
To: Kirill Yukhin, Serge Petrenko; +Cc: tarantool-patches
On heavy loaded hosts found the following issue:
[089] --- replication/gh-4928-tx-boundaries.result Wed Jul 29 04:08:29 2020
[089] +++ replication/gh-4928-tx-boundaries.reject Wed Jul 29 04:24:02 2020
[089] @@ -94,7 +94,7 @@
[089] | ...
[089] box.info.replication[1].upstream.status
[089] | ---
[089] - | - follow
[089] + | - disconnected
[089] | ...
[089]
[089] box.space.glob:select{}
It happend because replication upstream status check happend to early,
when it was in only in 'disconnected' state. To give the replication
status check routine ability to reach the needed 'follow' state it need
to wait for it using test_run:wait_upstream() routine.
Closes #5234
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928
Issue: https://github.com/tarantool/tarantool/issues/5234
test/replication/gh-4928-tx-boundaries.result | 4 ++--
test/replication/gh-4928-tx-boundaries.test.lua | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result
index 969bd8438..4bd1b4b25 100644
--- a/test/replication/gh-4928-tx-boundaries.result
+++ b/test/replication/gh-4928-tx-boundaries.result
@@ -92,9 +92,9 @@ box.info.status
| ---
| - running
| ...
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
| ---
- | - follow
+ | - true
| ...
box.space.glob:select{}
diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua
index 92526fc51..f245bff74 100644
--- a/test/replication/gh-4928-tx-boundaries.test.lua
+++ b/test/replication/gh-4928-tx-boundaries.test.lua
@@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock)
test_run:cmd('switch replica')
box.info.status
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
box.space.glob:select{}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test
2020-09-05 19:56 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test Alexander V. Tikhonov
@ 2020-09-09 15:33 ` Serge Petrenko
0 siblings, 0 replies; 3+ messages in thread
From: Serge Petrenko @ 2020-09-09 15:33 UTC (permalink / raw)
To: Alexander V. Tikhonov, Kirill Yukhin; +Cc: tarantool-patches
05.09.2020 22:56, Alexander V. Tikhonov пишет:
> On heavy loaded hosts found the following issue:
>
> [089] --- replication/gh-4928-tx-boundaries.result Wed Jul 29 04:08:29 2020
> [089] +++ replication/gh-4928-tx-boundaries.reject Wed Jul 29 04:24:02 2020
> [089] @@ -94,7 +94,7 @@
> [089] | ...
> [089] box.info.replication[1].upstream.status
> [089] | ---
> [089] - | - follow
> [089] + | - disconnected
> [089] | ...
> [089]
> [089] box.space.glob:select{}
>
> It happend because replication upstream status check happend to early,
> when it was in only in 'disconnected' state. To give the replication
> status check routine ability to reach the needed 'follow' state it need
> to wait for it using test_run:wait_upstream() routine.
>
> Closes #5234
Thanks for the patch! LGTM.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928
> Issue: https://github.com/tarantool/tarantool/issues/5234
>
> test/replication/gh-4928-tx-boundaries.result | 4 ++--
> test/replication/gh-4928-tx-boundaries.test.lua | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result
> index 969bd8438..4bd1b4b25 100644
> --- a/test/replication/gh-4928-tx-boundaries.result
> +++ b/test/replication/gh-4928-tx-boundaries.result
> @@ -92,9 +92,9 @@ box.info.status
> | ---
> | - running
> | ...
> -box.info.replication[1].upstream.status
> +test_run:wait_upstream(1, {status = 'follow'})
> | ---
> - | - follow
> + | - true
> | ...
>
> box.space.glob:select{}
> diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua
> index 92526fc51..f245bff74 100644
> --- a/test/replication/gh-4928-tx-boundaries.test.lua
> +++ b/test/replication/gh-4928-tx-boundaries.test.lua
> @@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock)
> test_run:cmd('switch replica')
>
> box.info.status
> -box.info.replication[1].upstream.status
> +test_run:wait_upstream(1, {status = 'follow'})
>
> box.space.glob:select{}
>
--
Serge Petrenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test
2020-09-06 15:36 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4402-info-errno.test.lua Alexander V. Tikhonov
@ 2020-09-06 15:36 ` Alexander V. Tikhonov
0 siblings, 0 replies; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-09-06 15:36 UTC (permalink / raw)
To: Kirill Yukhin, Serge Petrenko; +Cc: tarantool-patches
On heavy loaded hosts found the following issue:
[089] --- replication/gh-4928-tx-boundaries.result Wed Jul 29 04:08:29 2020
[089] +++ replication/gh-4928-tx-boundaries.reject Wed Jul 29 04:24:02 2020
[089] @@ -94,7 +94,7 @@
[089] | ...
[089] box.info.replication[1].upstream.status
[089] | ---
[089] - | - follow
[089] + | - disconnected
[089] | ...
[089]
[089] box.space.glob:select{}
It happened because replication upstream status check occurred too
early, when it was only in 'disconnected' state. To give the
replication status check routine ability to reach the needed 'follow'
state, it need to wait for it using test_run:wait_upstream() routine.
Closes #5234
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928
Issue: https://github.com/tarantool/tarantool/issues/5234
test/replication/gh-4928-tx-boundaries.result | 4 ++--
test/replication/gh-4928-tx-boundaries.test.lua | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result
index 969bd8438..4bd1b4b25 100644
--- a/test/replication/gh-4928-tx-boundaries.result
+++ b/test/replication/gh-4928-tx-boundaries.result
@@ -92,9 +92,9 @@ box.info.status
| ---
| - running
| ...
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
| ---
- | - follow
+ | - true
| ...
box.space.glob:select{}
diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua
index 92526fc51..f245bff74 100644
--- a/test/replication/gh-4928-tx-boundaries.test.lua
+++ b/test/replication/gh-4928-tx-boundaries.test.lua
@@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock)
test_run:cmd('switch replica')
box.info.status
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
box.space.glob:select{}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 19:56 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test Alexander V. Tikhonov
2020-09-09 15:33 ` Serge Petrenko
2020-09-06 15:36 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4402-info-errno.test.lua Alexander V. Tikhonov
2020-09-06 15:36 ` [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test Alexander V. Tikhonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox