From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B8233469719 for ; Sun, 6 Sep 2020 18:36:55 +0300 (MSK) From: "Alexander V. Tikhonov" Date: Sun, 6 Sep 2020 18:36:51 +0300 Message-Id: <6199896fa901b4cdad17818688e22aac199f6ac7.1599405347.git.avtikhon@tarantool.org> In-Reply-To: References: Subject: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin , Serge Petrenko Cc: tarantool-patches@dev.tarantool.org On heavy loaded hosts found the following issue: [089] --- replication/gh-4928-tx-boundaries.result Wed Jul 29 04:08:29 2020 [089] +++ replication/gh-4928-tx-boundaries.reject Wed Jul 29 04:24:02 2020 [089] @@ -94,7 +94,7 @@ [089] | ... [089] box.info.replication[1].upstream.status [089] | --- [089] - | - follow [089] + | - disconnected [089] | ... [089] [089] box.space.glob:select{} It happened because replication upstream status check occurred too early, when it was only in 'disconnected' state. To give the replication status check routine ability to reach the needed 'follow' state, it need to wait for it using test_run:wait_upstream() routine. Closes #5234 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928 Issue: https://github.com/tarantool/tarantool/issues/5234 test/replication/gh-4928-tx-boundaries.result | 4 ++-- test/replication/gh-4928-tx-boundaries.test.lua | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result index 969bd8438..4bd1b4b25 100644 --- a/test/replication/gh-4928-tx-boundaries.result +++ b/test/replication/gh-4928-tx-boundaries.result @@ -92,9 +92,9 @@ box.info.status | --- | - running | ... -box.info.replication[1].upstream.status +test_run:wait_upstream(1, {status = 'follow'}) | --- - | - follow + | - true | ... box.space.glob:select{} diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua index 92526fc51..f245bff74 100644 --- a/test/replication/gh-4928-tx-boundaries.test.lua +++ b/test/replication/gh-4928-tx-boundaries.test.lua @@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock) test_run:cmd('switch replica') box.info.status -box.info.replication[1].upstream.status +test_run:wait_upstream(1, {status = 'follow'}) box.space.glob:select{} -- 2.17.1