From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 715E3469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  9 Sep 2020 18:33:29 +0300 (MSK)
References: <48d336a709872d28d44dd1d2f2f489cf5df22404.1599335715.git.avtikhon@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <c802a749-780c-d31f-9696-84ed95201555@tarantool.org>
Date: Wed, 9 Sep 2020 18:33:27 +0300
MIME-Version: 1.0
In-Reply-To: <48d336a709872d28d44dd1d2f2f489cf5df22404.1599335715.git.avtikhon@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky
	replication/gh-4928-tx-boundaries test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


05.09.2020 22:56, Alexander V. Tikhonov пишет:
> On heavy loaded hosts found the following issue:
>
>    [089] --- replication/gh-4928-tx-boundaries.result	Wed Jul 29 04:08:29 2020
>    [089] +++ replication/gh-4928-tx-boundaries.reject	Wed Jul 29 04:24:02 2020
>    [089] @@ -94,7 +94,7 @@
>    [089]   | ...
>    [089]  box.info.replication[1].upstream.status
>    [089]   | ---
>    [089] - | - follow
>    [089] + | - disconnected
>    [089]   | ...
>    [089]
>    [089]  box.space.glob:select{}
>
> It happend because replication upstream status check happend to early,
> when it was in only in 'disconnected' state. To give the replication
> status check routine ability to reach the needed 'follow' state it need
> to wait for it using test_run:wait_upstream() routine.
>
> Closes #5234


Thanks for the  patch! LGTM.

> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928
> Issue: https://github.com/tarantool/tarantool/issues/5234
>
>   test/replication/gh-4928-tx-boundaries.result   | 4 ++--
>   test/replication/gh-4928-tx-boundaries.test.lua | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result
> index 969bd8438..4bd1b4b25 100644
> --- a/test/replication/gh-4928-tx-boundaries.result
> +++ b/test/replication/gh-4928-tx-boundaries.result
> @@ -92,9 +92,9 @@ box.info.status
>    | ---
>    | - running
>    | ...
> -box.info.replication[1].upstream.status
> +test_run:wait_upstream(1, {status = 'follow'})
>    | ---
> - | - follow
> + | - true
>    | ...
>   
>   box.space.glob:select{}
> diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua
> index 92526fc51..f245bff74 100644
> --- a/test/replication/gh-4928-tx-boundaries.test.lua
> +++ b/test/replication/gh-4928-tx-boundaries.test.lua
> @@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock)
>   test_run:cmd('switch replica')
>   
>   box.info.status
> -box.info.replication[1].upstream.status
> +test_run:wait_upstream(1, {status = 'follow'})
>   
>   box.space.glob:select{}
>   

-- 
Serge Petrenko