From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/4] fiber: keep reference to userdata if fiber created once
Date: Fri, 3 Sep 2021 09:12:10 +0300 [thread overview]
Message-ID: <c760fa48-db1d-4db0-8dfd-b38661233572@tarantool.org> (raw)
In-Reply-To: <fb6facd4-1d3d-808e-4300-6bccfc55b442@tarantool.org>
On 03.09.2021 00:39, Vladislav Shpilevoy wrote:
>> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
>> index 588b78504..39b67f940 100644
>> --- a/src/lib/core/fiber.c
>> +++ b/src/lib/core/fiber.c
>> @@ -32,6 +32,7 @@
>>
>> #include <trivia/config.h>
>> #include <trivia/util.h>
>> +#include <lauxlib.h>
> Please, don't. Libcore should not depend on Lua anyhow.
I understand you but I don't see another way to initialize refs with
LUA_NOREF.
I tried to do it only for Lua-created fiber but there is fibers from the
pool and
they also required to be initialized. And in general any non-lua fiber
could be find with
fiber.find and referenced in Lua.
Do you have any ideas how it could be fixed?
next prev parent reply other threads:[~2021-09-03 6:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 20:33 [Tarantool-patches] [PATCH 0/4] " Oleg Babin via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 1/4] fiber: rename ref to fiber_ref Oleg Babin via Tarantool-patches
2021-09-02 15:22 ` Igor Munkin via Tarantool-patches
2021-09-02 18:00 ` Бабин Олег via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 2/4] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches
2021-09-02 15:22 ` Igor Munkin via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 3/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-08-25 20:33 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26 6:14 ` Oleg Babin via Tarantool-patches
2021-09-02 15:22 ` Igor Munkin via Tarantool-patches
2021-09-02 17:59 ` Бабин Олег via Tarantool-patches
2021-09-02 21:39 ` Vladislav Shpilevoy via Tarantool-patches
2021-09-03 6:12 ` Oleg Babin via Tarantool-patches [this message]
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool Oleg Babin via Tarantool-patches
2021-08-25 20:34 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26 6:14 ` Oleg Babin via Tarantool-patches
2021-08-26 20:01 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26 20:15 ` Oleg Babin via Tarantool-patches
2021-09-02 15:23 ` [Tarantool-patches] [PATCH 0/4] fiber: keep reference to userdata if fiber created once Igor Munkin via Tarantool-patches
2021-09-02 18:07 ` Бабин Олег via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c760fa48-db1d-4db0-8dfd-b38661233572@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/4] fiber: keep reference to userdata if fiber created once' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox