Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>, imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool
Date: Thu, 26 Aug 2021 22:01:04 +0200	[thread overview]
Message-ID: <52b6cba2-45d4-68ec-d4e1-b9dc2390091b@tarantool.org> (raw)
In-Reply-To: <817688b9-5419-0dea-d92d-74a82a9b8da6@tarantool.org>

On 26.08.2021 08:14, Oleg Babin via Tarantool-patches wrote:
> Thanks for your review. See my answers below.
> 
> On 25.08.2021 23:34, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> See 4 comments below.
>>
>> On 11.08.2021 22:33, Oleg Babin via Tarantool-patches wrote:
>>> From: Oleg Babin<babinoleg@mail.ru>
>>>
>>> Previously we use malloc for such purpose however we created
>>> on_stop triggers only if fiber storage was touched. Currently we
>>> create on_stop trigger for each lua fiber. So it seems reasonable
>>> to use mempool for such frequent allocations/deallocations.
>> 1. Does it give any perf win? This commit specifically. Seems like an
>> overkill. A trigger allocation might happen only once per fiber's
>> lifetime, and the fiber's creation is supposed to be much longer than
>> the trigger's malloc. The commit probably gives a tiny fraction of
>> percent improvement or does not change anything. Do you have results?
> 
> It's a good question. I thought thank mempool should be faster than malloc.
> 
> We can easily drop this commit. I had some doubts about it.

According to the benchmarks it seems the mempool here is slower.
I suggest to drop this commit.

  reply	other threads:[~2021-08-26 20:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 20:33 [Tarantool-patches] [PATCH 0/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 1/4] fiber: rename ref to fiber_ref Oleg Babin via Tarantool-patches
2021-09-02 15:22   ` Igor Munkin via Tarantool-patches
2021-09-02 18:00     ` Бабин Олег via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 2/4] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches
2021-09-02 15:22   ` Igor Munkin via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 3/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-08-25 20:33   ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26  6:14     ` Oleg Babin via Tarantool-patches
2021-09-02 15:22   ` Igor Munkin via Tarantool-patches
2021-09-02 17:59     ` Бабин Олег via Tarantool-patches
2021-09-02 21:39       ` Vladislav Shpilevoy via Tarantool-patches
2021-09-03  6:12         ` Oleg Babin via Tarantool-patches
2021-08-11 20:33 ` [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool Oleg Babin via Tarantool-patches
2021-08-25 20:34   ` Vladislav Shpilevoy via Tarantool-patches
2021-08-26  6:14     ` Oleg Babin via Tarantool-patches
2021-08-26 20:01       ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-08-26 20:15         ` Oleg Babin via Tarantool-patches
2021-09-02 15:23 ` [Tarantool-patches] [PATCH 0/4] fiber: keep reference to userdata if fiber created once Igor Munkin via Tarantool-patches
2021-09-02 18:07   ` Бабин Олег via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52b6cba2-45d4-68ec-d4e1-b9dc2390091b@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 4/4] fiber: allocate on_stop triggers using mempool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox