Re: [Tarantool-patches] [PATCH 1/4] fiber: rename ref to fiber_ref

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Oleg,

Thanks for the patch! LGTM since the changes are trivial, but consider
the nits below.

On 11.08.21, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> Ref is a lua reference to fiber storage. This patch just renames
> storage.lua.ref to storage_ref to underline that it's not a

Minor: This line seems ambiguous (at least to me). You're writing about
storage.lua.ref, so the renamed field should be storage.lua.storage_ref.
Feel free to ignore.

> reference to fiber itself and needed only for fiber storage.
> ---
>  src/lib/core/fiber.h |  2 +-
>  src/lua/fiber.c      | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h
> index b85625ba7..593847df7 100644
> --- a/src/lib/core/fiber.h
> +++ b/src/lib/core/fiber.h
> @@ -626,7 +626,7 @@ struct fiber {
>  			/**
>  			 * Optional fiber.storage Lua reference.
>  			 */
> -			int ref;
> +			int storage_ref;

Typo: You're writing about <fiber_ref> in the commit subject, but the
patch is about <storage_ref>.

>  		} lua;
>  		/**
>  		 * Iproto sync.

<snipped>

> -- 
> 2.32.0
> 

-- 
Best regards,
IM