From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7407870C99; Thu, 2 Sep 2021 18:47:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7407870C99 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1630597637; bh=kCsIwiHu/+zCgwX6Gx5rQOdGU0OqbiqeCvcFNXbc/dQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MpleBH0uc5xxe134GEpMzr9MscaIhxmiN6aI90h/HGBJ/SSgWrF3F3vl73Nknc4at LgXryH9Vzv3q8YpiaXDk9p+KwfcS4yklOFFW3wobtBeyC2/n8nMZs4AtoIzeCcLom5 UOHdnXeabwoVrx1TF93Mwy37j3ZeMURTsS89loqM= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8595670C99 for ; Thu, 2 Sep 2021 18:47:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8595670C99 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mLovq-0004TG-Fn; Thu, 02 Sep 2021 18:47:14 +0300 Date: Thu, 2 Sep 2021 18:22:00 +0300 To: olegrok@tarantool.org Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20210902152200.GR5743@tarantool.org> References: <163ea2c0eb0172a784e29e5ea61f22e336e969a5.1628713520.git.babinoleg@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <163ea2c0eb0172a784e29e5ea61f22e336e969a5.1628713520.git.babinoleg@mail.ru> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9D96C1EA41D18F4D509A18445EEC42850342F4D29854BE689182A05F538085040C166FB9B5571A49D8CC8EB56FE5A7E982527ABC198A76D2F6684E5453FEBB3CA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371DF52D98DC3592C48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A3DB3651455C02E404DDC5ED7B333C97117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BE9D2F02AC1970E4575ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A56E237E9EA4366F231E3BD339F2F6641A1A7B255A4ED74C14D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D15449C5538BAB7CA86131FA502D771C024EEB26560029FF7E7FD2FDBC459B7D571D7E09C32AA3244CF3046DDDB8158A3AF7F2055BB67B56424DBEAD0ED6C55A80927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojK/h3ZnmlPjFHqQNNsWKY8g== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4091D775A3BCE287FFA9B7639B9F0BBCA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/4] fiber: rename ref to fiber_ref X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Oleg, Thanks for the patch! LGTM since the changes are trivial, but consider the nits below. On 11.08.21, olegrok@tarantool.org wrote: > From: Oleg Babin > > Ref is a lua reference to fiber storage. This patch just renames > storage.lua.ref to storage_ref to underline that it's not a Minor: This line seems ambiguous (at least to me). You're writing about storage.lua.ref, so the renamed field should be storage.lua.storage_ref. Feel free to ignore. > reference to fiber itself and needed only for fiber storage. > --- > src/lib/core/fiber.h | 2 +- > src/lua/fiber.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/lib/core/fiber.h b/src/lib/core/fiber.h > index b85625ba7..593847df7 100644 > --- a/src/lib/core/fiber.h > +++ b/src/lib/core/fiber.h > @@ -626,7 +626,7 @@ struct fiber { > /** > * Optional fiber.storage Lua reference. > */ > - int ref; > + int storage_ref; Typo: You're writing about in the commit subject, but the patch is about . > } lua; > /** > * Iproto sync. > -- > 2.32.0 > -- Best regards, IM