From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CFD406FC85; Fri, 3 Sep 2021 09:12:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CFD406FC85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1630649533; bh=vKgYPi2BiZEtbuYflvFz8RGlUI120FTwalROKoGRg1Q=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lkMZ9VTCc9SxEf97BUJhnGXnbg/P1NDS08nhcZ7HXXKvcdpCkD6OVRLLBPv1o1oQq BxFBoEUKIvl35aL0dyeEEL7ZU1CyWGsa1QXsz7OmNzzK9bIehwPzynVQ34DdLyQAQm q2+QThYlsh8T42RzI40KG5oTqQUB2T7qOcAUy2YU= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C0B6D6FC85 for ; Fri, 3 Sep 2021 09:12:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0B6D6FC85 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1mM2Qt-0001OB-UG; Fri, 03 Sep 2021 09:12:12 +0300 To: Vladislav Shpilevoy , Igor Munkin Cc: tarantool-patches@dev.tarantool.org References: <3453bc40af586cf4242863f1307f72fe5c5a408a.1628713520.git.babinoleg@mail.ru> <20210902152255.GT5743@tarantool.org> <1630605573.465905120@f386.i.mail.ru> Message-ID: Date: Fri, 3 Sep 2021 09:12:10 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D96C1EA41D18F4D5024F685B875086397E6085D2F3B7D615182A05F538085040D8F1E62815069DC363E5D0341C010034C8F5BC93294C5DD318E9CE880126FF8D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637652CD06254D2F21C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8594112EB7A6CC73D88D116EA9ADEDF57117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC1F8789D36234D406A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86DF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CE95D17AC60882304040F9FF01DFDA4A84AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3776FEBA3834A766EBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE75B51C8FB0C3E748C731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50599988EE298F60460CED0C7492695C676 X-C1DE0DAB: 0D63561A33F958A589E30204B217F924E945D5CD5EB786CC6B07673C23030F35D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCF6862F219EC5DB4DB458D613523574F33B81631EFC6CFEF4684866766710B923D1D7E09C32AA3244C12A27B80B7352725D153F4F31DC8A56630363D8B7DA7DD44FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioja9FuITQvsRqd8BEOaXWwwg== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6BE98C96D6D2355ADC63E5D0341C0100345AB84C59671071107019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] fiber: keep reference to userdata if fiber created once X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 03.09.2021 00:39, Vladislav Shpilevoy wrote: >> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c >> index 588b78504..39b67f940 100644 >> --- a/src/lib/core/fiber.c >> +++ b/src/lib/core/fiber.c >> @@ -32,6 +32,7 @@ >> >>  #include >>  #include >> +#include > Please, don't. Libcore should not depend on Lua anyhow. I understand you but I don't see another way to initialize refs with LUA_NOREF. I tried to do it only for Lua-created fiber but there is fibers from the pool and they also required to be initialized. And in general any non-lua fiber could be find with fiber.find and referenced in Lua. Do you have any ideas how it could be fixed?