From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events Date: Tue, 13 Apr 2021 13:38:14 +0300 [thread overview] Message-ID: <c14d25b1-e3b4-f3eb-3955-bd6ad5864729@tarantool.org> (raw) In-Reply-To: <20210413083137.k6min7inv6ybj7yy@tkn_work_nb> 13.04.2021 11:31, Alexander Turenko пишет: >> @@ -462,6 +468,8 @@ box.schema.space.create = function(name, options) >> }) >> _space:insert{id, uid, name, options.engine, options.field_count, >> space_options, format} >> + >> + feedback_save_event('create_space') >> return box.space[id], "created" >> end > What the counter will show, if I bootstrap an instance from an existing > snapshot with N spaces and add one more? The counter will be 1 again. It shows 'how many events have occured since tarantool startup`. An event here is user calling `box.schema.space.create` > > Will it count spaces that starts from the underscore symbol (queue and > memcached modules create such spaces)? Yes, it counts every space which was created with `box.schema.space.create`. If you do `_space:insert{new_space_id, new_space_name, ...}` (I don't remember the exact format but you get the idea), such an event won't be counted. > > WBR, Alexander Turenko. -- Serge Petrenko
next prev parent reply other threads:[~2021-04-13 10:38 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 13:38 [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 1/5] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches 2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 4/5] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches 2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events Serge Petrenko via Tarantool-patches 2021-04-13 8:31 ` Alexander Turenko via Tarantool-patches 2021-04-13 10:38 ` Serge Petrenko via Tarantool-patches [this message] 2021-04-11 14:15 ` [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Vladislav Shpilevoy via Tarantool-patches 2021-04-12 6:04 ` Kirill Yukhin via Tarantool-patches 2021-04-13 9:44 ` Alexander Turenko via Tarantool-patches 2021-04-12 6:05 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c14d25b1-e3b4-f3eb-3955-bd6ad5864729@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox