Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events
Date: Mon, 12 Apr 2021 06:05:10 +0000	[thread overview]
Message-ID: <20210412060509.2dl6sairr52wezpn@tarantool.org> (raw)
In-Reply-To: <cover.1617888916.git.sergepetrenko@tarantool.org>

Hello,

On 08 апр 16:38, Serge Petrenko via Tarantool-patches wrote:
> Changes in v2:
>   - add event reporting in patch 5
>   - add a workaround for failing tests:
>     sleep for 10 seconds before the first ever report dispatch.
>   - minor review fixes
> 
> https://github.com/tarantool/tarantool/issues/5750
> https://github.com/tarantool/tarantool/tree/sp/gh-5750-feedback-on-start
> 
> Serge Petrenko (5):
>   feedback_daemon: include server uptime in the report
>   feedback_daemon: rename `send_test` to `send`
>   feedback_daemon: send feedback on server start
>   feedback_daemon: generate report right before sending
>   feedback_daemon: count and report some events
> 
>  src/box/lua/feedback_daemon.lua       | 49 ++++++++++++++++++++++----
>  src/box/lua/load_cfg.lua              | 34 ++++++++++++------
>  src/box/lua/schema.lua                | 14 ++++++++
>  test/box-tap/feedback_daemon.test.lua | 50 ++++++++++++++++++++-------
>  4 files changed, 118 insertions(+), 29 deletions(-)

I've checked your patchset into master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-04-12  6:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 13:38 Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 1/5] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send` Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches
2021-04-09 21:53   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:03     ` Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 4/5] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches
2021-04-09 21:53   ` Vladislav Shpilevoy via Tarantool-patches
2021-04-10 15:03     ` Serge Petrenko via Tarantool-patches
2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events Serge Petrenko via Tarantool-patches
2021-04-13  8:31   ` Alexander Turenko via Tarantool-patches
2021-04-13 10:38     ` Serge Petrenko via Tarantool-patches
2021-04-11 14:15 ` [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Vladislav Shpilevoy via Tarantool-patches
2021-04-12  6:04   ` Kirill Yukhin via Tarantool-patches
2021-04-13  9:44     ` Alexander Turenko via Tarantool-patches
2021-04-12  6:05 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412060509.2dl6sairr52wezpn@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox