From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Serge Petrenko <sergepetrenko@tarantool.org>, alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Date: Sun, 11 Apr 2021 16:15:07 +0200 [thread overview] Message-ID: <c305479d-618c-e4e8-068f-15e266b294e9@tarantool.org> (raw) In-Reply-To: <cover.1617888916.git.sergepetrenko@tarantool.org> Thanks for the patchset, Sergey! Technically the patchset looks bearable. Below text is for the people who forced us to do this ticket. Disclaimer: this is not toxic. I mostly just ask questions and express my opinion. I don't like the patch. The hack to workaround some CI issues with a sleep, and the behaviour we introduce on the whole. I don't think creation of a first space/index makes any sense to track. The reason about "going through a tutorial" is a very weak argument. Spaces are created not only as a part of a tutorial obviously. And I see no other reason for sending these "events". This rant is for Mons, Artur, and whoever else pushed sending of that useless information and introduction of a **known bug** which we hack with 10s sleep. I bet they have no idea how to really use it **exactly**, not in some abstract way they will try to figure out later, and they just wanted to send "something" to close some story-points. We on purpose **push buggy code** only to send these feedback events we don't know what to do with. Here is what I see in the issue: In order for us to assess the real situation for the product, it is necessary to send feedback from the product immediately after the launch and after the key actions are completed. How the hell is it related to a "real situation for the product"? How is it "necessary"? What was wrong with the feedback we have now? How are the instances working less than 1 hour are so important? And why do you need to know exactly when a first space/index was created? Well, even if we need it, we could remember the timestamps and send them with the next regular report. Another cite: If Tarantool was installed using a script from the Download page, then you need to send feedback immediately and further after the following events are completed: ... The rest of Tarantool that were downloaded outside of the Download page does not contain a special meta-file and should be considered as internal usage and no feedback sent from them. These are usually CI instances. What is that "metafile"? We send the feedback anyway regardless of some metafile in this patch, and from where the executable file was downloaded. Which again renders this "feature" absolutely useless. Besides, creation of a first index and space won't cover instances which don't create any indexes and spaces. For example, vshard routers. Additionally, implementation of this code stole time from the scaling team on writing the code, doing the reviews, doing the review fixes. How is it even related to the scaling team at all? Why was it so urgent and more important than finishing a fix for a serious bug in the synchronous replication? I would propose Artur to send a PR for that next time. Tickets like that should go to the wishlist right away, instead of the known crashes and optimizations. I hope we will drop these feedback events in the future when will realize it does not help anyhow with a problem which can't even be properly formulated, and because it introduces a bug we don't know for sure why is happening, and how can be fixed except the 10s sleep hack.
next prev parent reply other threads:[~2021-04-11 14:15 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-08 13:38 Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 1/5] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches 2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 4/5] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches 2021-04-09 21:53 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-10 15:03 ` Serge Petrenko via Tarantool-patches 2021-04-08 13:38 ` [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events Serge Petrenko via Tarantool-patches 2021-04-13 8:31 ` Alexander Turenko via Tarantool-patches 2021-04-13 10:38 ` Serge Petrenko via Tarantool-patches 2021-04-11 14:15 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-04-12 6:04 ` [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events Kirill Yukhin via Tarantool-patches 2021-04-13 9:44 ` Alexander Turenko via Tarantool-patches 2021-04-12 6:05 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c305479d-618c-e4e8-068f-15e266b294e9@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox