From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A4EB6BD18; Mon, 12 Apr 2021 09:05:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A4EB6BD18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618207513; bh=TYqkgbjQHhIgieOIN4m9+n//+Joh+4mWy6jo4iBidSE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cKwB/qdcNFvMEsCoxe7VTcaHALO5DueyKL0RSSrsoENCE+T0YU1j1S45qZ5yXV6Ju GEBVyiX3OoBKttuOST84sPoMp8BB1lSIJd1RUBXi8G0wJt7Hp8iCp6aGqxOpUi9amr HKabjRf53cVfeM7LucYMURqVpUCIoh/Edwdl0bgo= Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CB4C36EC5B for ; Mon, 12 Apr 2021 09:05:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB4C36EC5B Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1lVph8-00050E-8g; Mon, 12 Apr 2021 09:05:10 +0300 Date: Mon, 12 Apr 2021 06:05:10 +0000 To: Serge Petrenko Cc: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20210412060509.2dl6sairr52wezpn@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F538085040842FFA4C25E108E95D430C3A1B7A54127D2F13931A5E1431FC285F1F38A00D88 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BFD6B3F1638522B88638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B21B76A74B09F4790DE7057EF6FEFBE8204A8204C501E24153D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE76ED13AF7AA8AEC2BD32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0452896749CDDA0A6B3661434B16C20AC78D18283394535A9E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6023D27916A5D611C089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A53CEB196D3DBFDF75CE3E99B9E970AC6E2987E1FE40730655D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A59E724FC7897F7F97AABF73C9271825B71DE1AC0A36548DA333F3E687CF722FD6833969E534A0F1D7E09C32AA3244CC3626121464F2F490F82CB95D05A93127C0C08F7987826B9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq8JA+pXcDulxxQrOnG2K0g== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2842C375EEF06F1FB97186F46D88625CA52D379300B091A86CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 08 апр 16:38, Serge Petrenko via Tarantool-patches wrote: > Changes in v2: > - add event reporting in patch 5 > - add a workaround for failing tests: > sleep for 10 seconds before the first ever report dispatch. > - minor review fixes > > https://github.com/tarantool/tarantool/issues/5750 > https://github.com/tarantool/tarantool/tree/sp/gh-5750-feedback-on-start > > Serge Petrenko (5): > feedback_daemon: include server uptime in the report > feedback_daemon: rename `send_test` to `send` > feedback_daemon: send feedback on server start > feedback_daemon: generate report right before sending > feedback_daemon: count and report some events > > src/box/lua/feedback_daemon.lua | 49 ++++++++++++++++++++++---- > src/box/lua/load_cfg.lua | 34 ++++++++++++------ > src/box/lua/schema.lua | 14 ++++++++ > test/box-tap/feedback_daemon.test.lua | 50 ++++++++++++++++++++------- > 4 files changed, 118 insertions(+), 29 deletions(-) I've checked your patchset into master. -- Regards, Kirill Yukhin