From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ECB5F6BD29; Tue, 13 Apr 2021 13:38:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECB5F6BD29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618310298; bh=1jJAJc8BhhoihxUujSjtJ15+ed7h78GlOkUiXGrpPC0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bbEEp3c1xVCc2LXYSxHmD4cUmzOsf6oDfWwZZePoLavbFeHMoqlSGmXSIi5OKLBOU bROcG8cqI2qUb+/y1swHTP9lgUUxB0Iz+onGTu+OO/mk6JnI2Vz4AwpBzpk6qmiy72 F5P8Y5CaudHWH7s8mPG/EEM7jP6Pa6dgVUU4Ymxg= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 46BF06BD29 for ; Tue, 13 Apr 2021 13:38:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 46BF06BD29 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1lWGQw-0002Hq-KX; Tue, 13 Apr 2021 13:38:14 +0300 To: Alexander Turenko Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org References: <94310caa91eac51c74dcde413407de12bd935a85.1617888916.git.sergepetrenko@tarantool.org> <20210413083137.k6min7inv6ybj7yy@tkn_work_nb> Message-ID: Date: Tue, 13 Apr 2021 13:38:14 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210413083137.k6min7inv6ybj7yy@tkn_work_nb> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F5380850402FFA99B2B1F652AF6E32D9C6682AEF539B8ED346C698C77A2FBD512260450970 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78C6616F30072131EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374DF0C582D42FCA168638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2451F651CD339B061EA80944841EF011F44A6ACC89FD899E7D2E47CDBA5A96583C09775C1D3CA48CFED8438A78DFE0A9E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE753BA49F501F20C09D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0BF77E1FFDBD4BA81CD04E86FAF290E2D4AB7DE70F7409F1A1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A51038EBE4FD2408A507956E678A682445F62C4F427740AE64D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF1D7DBB6FCFCCC159AD9C92E6028EE1430DAF4AD1A8A560F53F7623C65A3D2EBE71D7E09C32AA3244CC4DC0C66A07B0E331856C7AD8984AE0230452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXFOZ2ijEnp/Ww== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F80BC6A3726CD257D46EE2F2393C180629C688BF8F911ED684424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 5/5] feedback_daemon: count and report some events X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 13.04.2021 11:31, Alexander Turenko пишет: >> @@ -462,6 +468,8 @@ box.schema.space.create = function(name, options) >> }) >> _space:insert{id, uid, name, options.engine, options.field_count, >> space_options, format} >> + >> + feedback_save_event('create_space') >> return box.space[id], "created" >> end > What the counter will show, if I bootstrap an instance from an existing > snapshot with N spaces and add one more? The counter will be 1 again. It shows 'how many events have occured since tarantool startup`. An event here is user calling `box.schema.space.create` > > Will it count spaces that starts from the underscore symbol (queue and > memcached modules create such spaces)? Yes, it counts every space which was created with `box.schema.space.create`. If you do `_space:insert{new_space_id, new_space_name, ...}` (I don't remember the exact format but you get the idea), such an event won't be counted. > > WBR, Alexander Turenko. -- Serge Petrenko