From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS
Date: Thu, 2 Jul 2026 22:23:09 +0300 [thread overview]
Message-ID: <aka6nR_-jquO3WxF@root> (raw)
In-Reply-To: <1031cf25-dc8c-44ee-be9c-afa6578e0c54@tarantool.org>
Hi, Sergey!
Thanks for the review!
On 02.07.26, Sergey Bronnikov wrote:
> Sergey,
>
> seems it is not an OS-specific issue.
>
> strace reports that glibc is looking for /etc/localtime, but the file
> does not exist:
>
> strace ./src/luajit -e "print(os.time(os.date('*t', -1)))"
>
> <snipped>
>
> futex(0x70d8ab961070, FUTEX_WAKE_PRIVATE, 2147483647) = 0
> rt_sigaction(SIGINT, {sa_handler=0x4057e5, sa_mask=[INT],
> sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x70d8ab79bfd0},
> {sa_handler=SIG_DFL, sa_mask=[], sa_flags=0}, 8) = 0
> openat(AT_FDCWD, "/etc/localtime", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No
> such file or directory)
> openat(AT_FDCWD, "/etc/localtime", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No
> such file or directory)
> newfstatat(1, "", {st_mode=S_IFCHR|0620, st_rdev=makedev(0x88, 0), ...},
> AT_EMPTY_PATH) = 0
> write(1, "nil\n", 4nil
> ) = 4
> rt_sigaction(SIGINT, {sa_handler=SIG_DFL, sa_mask=[INT],
> sa_flags=SA_RESTORER|SA_RESTART, sa_restorer=0x70d8ab79bfd0},
> {sa_handler=0x4057e5, sa_mask=[INT], sa_flags=SA_RESTORER|SA_RESTART,
> sa_restorer=0x70d8ab79bfd0}, 8) = 0
> munmap(0x414e2000, 131072) = 0
> exit_group(0) = ?
> +++ exited with 0 +++
>
>
> The same issue can be reproduced on other Linux distros after removing
> /etc/localtime.
>
> On redOS the issue can be fixed by creating a symlink:
>
> ln -sf /usr/share/zoneinfo/Europe/Moscow /etc/localtime
>
> <snipped>
>
> ctest -V -R lj-1470-os-time-epoch-minus-1s.test.lua
>
> <snipped>
>
> The following tests passed:
> test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
>
> 100% tests passed, 0 tests failed out of 1
>
> Label Time Summary:
> tarantool-tests = 0.00 sec*proc (1 test)
>
> Total Test time (real) = 0.01 sec
>
>
> I propose checking a file /etc/localtime instead checking an OS name,
> this will be a more correct fix.
Indeed, this looks like much more bulletproof solution. Thanks for the
feedback! I've fixed this in v2 series [1].
<snipped>
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2026-July/030701.html
--
Best regards,
Sergey Kaplun
prev parent reply other threads:[~2026-07-02 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 14:28 Sergey Kaplun via Tarantool-patches
2026-07-02 14:45 ` Evgeniy Temirgaleev via Tarantool-patches
2026-07-02 16:02 ` Sergey Bronnikov via Tarantool-patches
2026-07-02 16:30 ` Sergey Bronnikov via Tarantool-patches
2026-07-02 19:23 ` Sergey Kaplun via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aka6nR_-jquO3WxF@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: skip lj-1470 test on RED OS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox